Merge pull request #1478 from matevzmihalic/fix-json-tag

Handle json tag without name override
ClickHouse · Jan 21, 2025 · 1195999 · 1195999
2 parents f6fea90 + 22edb2a
commit 1195999
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/examples/clickhouse_api/json_structs.go b/examples/clickhouse_api/json_structs.go
@@ -21,13 +21,14 @@ import (
 	"context"
 	"encoding/json"
 	"fmt"
-	"github.com/ClickHouse/clickhouse-go/v2"
 	"time"
+
+	"github.com/ClickHouse/clickhouse-go/v2"
 )
 
 type ProductPricing struct {
-	Price    int64  `json:"price"`
-	Currency string `json:"currency"`
+	Price    int64  `json:",omitempty"`
+	Currency string `json:",omitempty"`
 }
 
 type Product struct {

diff --git a/lib/column/json_reflect.go b/lib/column/json_reflect.go
@@ -78,7 +78,7 @@ func (c *JSON) fillStruct(val reflect.Value, prefix string, row int) error {
 		}
 
 		name := fieldType.Tag.Get("json")
-		if name == "" {
+		if name == "" || name[0] == ',' {
 			name = fieldType.Name
 		} else {
 			name = strings.Split(name, ",")[0]
@@ -311,7 +311,7 @@ func iterateStruct(val reflect.Value, prefix string, json *chcol.JSON) error {
 		}
 
 		name := fieldType.Tag.Get("json")
-		if name == "" {
+		if name == "" || name[0] == ',' {
 			name = fieldType.Name
 		} else {
 			// handle `json:"name,omitempty"`