Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proto): improve BCE in int decoding #8

Merged
merged 4 commits into from
Dec 26, 2021

Conversation

tdakkota
Copy link
Contributor

name                          old speed      new speed      delta
ColBool_Raw_DecodeColumn-4    9.25GB/s ± 2%  9.30GB/s ± 2%     ~     (p=0.056 n=15+15)
ColBool_DecodeColumn-4         735MB/s ± 3%   741MB/s ± 1%   +0.70%  (p=0.011 n=14+14)
ColDate32_DecodeColumn-4      2.39GB/s ± 1%  2.91GB/s ± 2%  +21.66%  (p=0.000 n=14+14)
ColDate_DecodeColumn-4        1.27GB/s ± 1%  1.57GB/s ± 0%  +23.32%  (p=0.000 n=14+12)
ColDateTime64_DecodeColumn-4  4.39GB/s ± 2%  5.21GB/s ± 2%  +18.57%  (p=0.000 n=15+15)
ColDateTime_DecodeColumn-4    2.40GB/s ± 1%  2.89GB/s ± 4%  +20.26%  (p=0.000 n=14+14)
ColDecimal128_DecodeColumn-4  3.02GB/s ± 2%  3.02GB/s ± 3%     ~     (p=0.983 n=14+15)
ColDecimal256_DecodeColumn-4  4.20GB/s ± 2%  4.19GB/s ± 3%     ~     (p=0.880 n=14+15)
ColDecimal32_DecodeColumn-4   2.41GB/s ± 1%  2.90GB/s ± 2%  +20.32%  (p=0.000 n=12+13)
ColDecimal64_DecodeColumn-4   4.39GB/s ± 4%  5.21GB/s ± 2%  +18.63%  (p=0.000 n=14+15)
ColEnum16_DecodeColumn-4      1.27GB/s ± 2%  1.56GB/s ± 2%  +22.26%  (p=0.000 n=14+15)
ColEnum8_DecodeColumn-4       1.39GB/s ± 3%  1.41GB/s ± 0%   +1.52%  (p=0.000 n=14+12)
ColFixedStr_DecodeColumn-4    14.1GB/s ± 1%  14.1GB/s ± 1%   -0.20%  (p=0.050 n=14+14)
ColFloat32_DecodeColumn-4     2.41GB/s ± 1%  2.89GB/s ± 2%  +20.19%  (p=0.000 n=14+15)
ColFloat64_DecodeColumn-4     4.40GB/s ± 1%  5.24GB/s ± 1%  +18.95%  (p=0.000 n=14+13)
ColInt128_DecodeColumn-4      3.01GB/s ± 3%  3.00GB/s ± 3%     ~     (p=0.158 n=15+14)
ColInt16_DecodeColumn-4       1.27GB/s ± 3%  1.55GB/s ± 2%  +21.98%  (p=0.000 n=15+15)
ColInt256_DecodeColumn-4      4.21GB/s ± 2%  4.20GB/s ± 4%     ~     (p=0.946 n=14+14)
ColInt32_DecodeColumn-4       2.41GB/s ± 1%  2.92GB/s ± 0%  +21.04%  (p=0.000 n=14+12)
ColInt64_DecodeColumn-4       4.40GB/s ± 2%  5.18GB/s ± 5%  +17.86%  (p=0.000 n=15+14)
ColInt8_DecodeColumn-4        1.40GB/s ± 1%  1.40GB/s ± 1%     ~     (p=0.726 n=14+14)
ColIPv4_DecodeColumn-4        2.41GB/s ± 0%  2.91GB/s ± 2%  +20.57%  (p=0.000 n=12+14)
ColIPv6_DecodeColumn-4        2.85GB/s ± 3%  2.93GB/s ± 2%   +2.66%  (p=0.000 n=14+15)
ColRaw_DecodeColumn-4         14.5GB/s ± 2%  14.6GB/s ± 2%     ~     (p=0.905 n=14+13)
ColStr_DecodeColumn-4          588MB/s ± 0%   549MB/s ± 3%   -6.64%  (p=0.000 n=12+15)
ColTuple_DecodeColumn-4       8.92GB/s ± 3%  8.95GB/s ± 2%     ~     (p=0.323 n=14+14)
ColUInt128_DecodeColumn-4     3.00GB/s ± 2%  3.00GB/s ± 2%     ~     (p=0.621 n=14+15)
ColUInt16_DecodeColumn-4      1.28GB/s ± 1%  1.56GB/s ± 0%  +22.50%  (p=0.000 n=15+12)
ColUInt256_DecodeColumn-4     4.21GB/s ± 3%  4.22GB/s ± 2%     ~     (p=0.880 n=15+14)
ColUInt32_DecodeColumn-4      2.42GB/s ± 0%  2.92GB/s ± 0%  +20.78%  (p=0.000 n=12+12)
ColUInt64_DecodeColumn-4      4.40GB/s ± 2%  5.23GB/s ± 2%  +18.89%  (p=0.000 n=15+14)
ColUInt8_DecodeColumn-4       7.76GB/s ± 2%  7.81GB/s ± 2%     ~     (p=0.141 n=14+13)
ColUUID_DecodeColumn-4        4.36GB/s ± 3%  4.37GB/s ± 1%     ~     (p=0.893 n=14+5)

Benchstat result:

name                          old speed      new speed      delta
ColBool_Raw_DecodeColumn-4    9.25GB/s ± 2%  9.30GB/s ± 2%     ~     (p=0.056 n=15+15)
ColBool_DecodeColumn-4         735MB/s ± 3%   741MB/s ± 1%   +0.70%  (p=0.011 n=14+14)
ColDate32_DecodeColumn-4      2.39GB/s ± 1%  2.91GB/s ± 2%  +21.66%  (p=0.000 n=14+14)
ColDate_DecodeColumn-4        1.27GB/s ± 1%  1.57GB/s ± 0%  +23.32%  (p=0.000 n=14+12)
ColDateTime64_DecodeColumn-4  4.39GB/s ± 2%  5.21GB/s ± 2%  +18.57%  (p=0.000 n=15+15)
ColDateTime_DecodeColumn-4    2.40GB/s ± 1%  2.89GB/s ± 4%  +20.26%  (p=0.000 n=14+14)
ColDecimal128_DecodeColumn-4  3.02GB/s ± 2%  3.02GB/s ± 3%     ~     (p=0.983 n=14+15)
ColDecimal256_DecodeColumn-4  4.20GB/s ± 2%  4.19GB/s ± 3%     ~     (p=0.880 n=14+15)
ColDecimal32_DecodeColumn-4   2.41GB/s ± 1%  2.90GB/s ± 2%  +20.32%  (p=0.000 n=12+13)
ColDecimal64_DecodeColumn-4   4.39GB/s ± 4%  5.21GB/s ± 2%  +18.63%  (p=0.000 n=14+15)
ColEnum16_DecodeColumn-4      1.27GB/s ± 2%  1.56GB/s ± 2%  +22.26%  (p=0.000 n=14+15)
ColEnum8_DecodeColumn-4       1.39GB/s ± 3%  1.41GB/s ± 0%   +1.52%  (p=0.000 n=14+12)
ColFixedStr_DecodeColumn-4    14.1GB/s ± 1%  14.1GB/s ± 1%   -0.20%  (p=0.050 n=14+14)
ColFloat32_DecodeColumn-4     2.41GB/s ± 1%  2.89GB/s ± 2%  +20.19%  (p=0.000 n=14+15)
ColFloat64_DecodeColumn-4     4.40GB/s ± 1%  5.24GB/s ± 1%  +18.95%  (p=0.000 n=14+13)
ColInt128_DecodeColumn-4      3.01GB/s ± 3%  3.00GB/s ± 3%     ~     (p=0.158 n=15+14)
ColInt16_DecodeColumn-4       1.27GB/s ± 3%  1.55GB/s ± 2%  +21.98%  (p=0.000 n=15+15)
ColInt256_DecodeColumn-4      4.21GB/s ± 2%  4.20GB/s ± 4%     ~     (p=0.946 n=14+14)
ColInt32_DecodeColumn-4       2.41GB/s ± 1%  2.92GB/s ± 0%  +21.04%  (p=0.000 n=14+12)
ColInt64_DecodeColumn-4       4.40GB/s ± 2%  5.18GB/s ± 5%  +17.86%  (p=0.000 n=15+14)
ColInt8_DecodeColumn-4        1.40GB/s ± 1%  1.40GB/s ± 1%     ~     (p=0.726 n=14+14)
ColIPv4_DecodeColumn-4        2.41GB/s ± 0%  2.91GB/s ± 2%  +20.57%  (p=0.000 n=12+14)
ColIPv6_DecodeColumn-4        2.85GB/s ± 3%  2.93GB/s ± 2%   +2.66%  (p=0.000 n=14+15)
ColRaw_DecodeColumn-4         14.5GB/s ± 2%  14.6GB/s ± 2%     ~     (p=0.905 n=14+13)
ColStr_DecodeColumn-4          588MB/s ± 0%   549MB/s ± 3%   -6.64%  (p=0.000 n=12+15)
ColTuple_DecodeColumn-4       8.92GB/s ± 3%  8.95GB/s ± 2%     ~     (p=0.323 n=14+14)
ColUInt128_DecodeColumn-4     3.00GB/s ± 2%  3.00GB/s ± 2%     ~     (p=0.621 n=14+15)
ColUInt16_DecodeColumn-4      1.28GB/s ± 1%  1.56GB/s ± 0%  +22.50%  (p=0.000 n=15+12)
ColUInt256_DecodeColumn-4     4.21GB/s ± 3%  4.22GB/s ± 2%     ~     (p=0.880 n=15+14)
ColUInt32_DecodeColumn-4      2.42GB/s ± 0%  2.92GB/s ± 0%  +20.78%  (p=0.000 n=12+12)
ColUInt64_DecodeColumn-4      4.40GB/s ± 2%  5.23GB/s ± 2%  +18.89%  (p=0.000 n=15+14)
ColUInt8_DecodeColumn-4       7.76GB/s ± 2%  7.81GB/s ± 2%     ~     (p=0.141 n=14+13)
ColUUID_DecodeColumn-4        4.36GB/s ± 3%  4.37GB/s ± 1%     ~     (p=0.893 n=14+5)
@ernado ernado merged commit 400f324 into ClickHouse:main Dec 26, 2021
@tdakkota tdakkota deleted the feat/improve-bce-for-int-decoding branch December 26, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants