Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use stable/oldstable versions of Go to test #426

Merged
merged 3 commits into from
Sep 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/cover.yml
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
name: cover

on:
# TODO: setup codecov
# https://github.com/ClickHouse/ch-go/issues/137
# push:
# branches:
# - main
# pull_request:
# TODO: setup codecov
# https://github.com/ClickHouse/ch-go/issues/137
# push:
# branches:
# - main
# pull_request:
workflow_dispatch:

jobs:
Expand All @@ -18,7 +18,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.21
go-version: oldstable

- name: Get Go environment
id: go-env
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ jobs:
fail-fast: true
matrix:
go:
- "1.20"
- "1.21"
- "oldstable"
- "stable"
clickhouse:
- v21.8.14.5-lts
- v22.3.11.12-lts
Expand All @@ -24,6 +24,7 @@ jobs:
- v23.3.8.21-lts
- v23.8.7.24-lts
- v23.10.3.5-stable
- v24.8.4.13-lts
steps:
- uses: actions/checkout@v4

Expand Down
27 changes: 15 additions & 12 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
linters-settings:
gosec:
excludes:
- G115 # Annoying and have a lot of false-positive results.
govet:
check-shadowing: true
gocyclo:
Expand Down Expand Up @@ -95,41 +98,41 @@ issues:

# Disable linters that are not needed for testing infra.
- path: internal/cht
linters: [ gosec ]
linters: [gosec]

- path: _test\.go
text: "Combine"
linters: [ gocritic ]
linters: [gocritic]

# Check that equal to self is true
- linters: [ gocritic ]
source: '(assert|require).+Equal'
text: 'dupArg'
- linters: [gocritic]
source: "(assert|require).+Equal"
text: "dupArg"
path: _test\.go

# Ignore shadowing of err.
- linters: [ govet ]
- linters: [govet]
text: 'declaration of "(err|ctx|log|lg|c)"'

# Probably some broken linter for generics?
- linters: [ revive ]
- linters: [revive]
text: 'receiver-naming: receiver name \S+ should be consistent with previous receiver name \S+ for invalid-type'

# Ignore linters in main packages.
- path: main\.go
linters: [ goconst, funlen, gocognit, gocyclo ]
linters: [goconst, funlen, gocognit, gocyclo]

- path: main\.go
linters: [ gosec ]
linters: [gosec]
text: "G307"

- source: 'func Fuzz.+\(f \*testing\.F\)'
linters: [ stylecheck ]
linters: [stylecheck]
text: "ST1003" # underscores lol

- path: (internal|cmd)
linters: [ revive ]
linters: [revive]
text: "package-comments"

- linters: [ revive ]
- linters: [revive]
text: "comment on exported const .+ should be of the form"
Loading