Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(proto): introduce StatefulColumn concept #31

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Conversation

ernado
Copy link
Collaborator

@ernado ernado commented Jan 30, 2022

Fix #30
Update #25
Update #22

@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #31 (fa1316c) into main (2a942e8) will decrease coverage by 1.10%.
The diff coverage is 58.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   84.65%   83.55%   -1.11%     
==========================================
  Files         110      111       +1     
  Lines        4588     4651      +63     
==========================================
+ Hits         3884     3886       +2     
- Misses        544      588      +44     
- Partials      160      177      +17     
Impacted Files Coverage Δ
proto/column.go 91.39% <ø> (ø)
proto/col_map.go 42.00% <17.64%> (-21.64%) ⬇️
proto/col_low_cardinality.go 63.86% <28.57%> (-13.62%) ⬇️
proto/col_tuple.go 83.33% <41.66%> (-16.67%) ⬇️
proto/block.go 73.13% <60.00%> (-0.51%) ⬇️
proto/results.go 70.10% <70.10%> (ø)
proto/col_arr.go 72.22% <85.71%> (-2.40%) ⬇️
proto/col_bool_unsafe.go 71.42% <0.00%> (-14.29%) ⬇️
proto/col_uuid_unsafe.go 81.81% <0.00%> (-9.10%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a942e8...fa1316c. Read the comment docs.

@ernado ernado merged commit aff6b28 into main Jan 30, 2022
@ernado ernado deleted the fix/stateful-columns branch January 30, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: invalid Array(LowCardinality(String)) serialization
1 participant