refactor: simplify overflow check

ClickHouse · Feb 14, 2025 · b64209f · b64209f
1 parent 05fba0a
commit b64209f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -13,3 +13,6 @@
 
 # Dependency directories (remove the comment below to include it)
 # vendor/
+
+# Editors
+.idea/
diff --git a/compress/writer.go b/compress/writer.go
@@ -58,9 +58,8 @@ func (w *Writer) Compress(m Method, buf []byte) error {
 		n = copy(w.Data[headerSize:], buf)
 	}
 
-	if n+headerSize > cap(w.Data) {
-		return errors.New("compressed data exceeds allocated buffer capacity")
-	} else if uint64(n)+uint64(compressHeaderSize) > math.MaxUint32 {
+	// security: https://github.com/ClickHouse/ch-go/pull/1041
+	if uint64(n)+uint64(compressHeaderSize) > math.MaxUint32 {
 		return errors.New("compressed size overflows uint32")
 	}