[MC-1739] PE File Variables #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds new CleverTap APIs onVariablesChangedAndNoDownloadsPending and onceVariablesChangedAndNoDownloadsPending. - Adds new fileIsReady callback in CTVarDelegate when file is downloaded.
- Updated logic to call fileIsReady when delegate is set.
- Update fileURL value also when file value has changed.
2ff84c3 to
e7fa620
Compare
nzagorchev
reviewed
Jul 11, 2024
| /** | ||
| * Called when the file is downloaded and ready. | ||
| */ | ||
| - (void)fileIsReady:(CTVar *)var; |
There was a problem hiding this comment.
Add onFileReady as a callback as well, similar to onValueChanged
| NSMutableArray<NSString *> *retryURLs; | ||
| // Call fileIsReady for variables whose files are downloaded. | ||
| for (NSString *key in status.allKeys) { | ||
| if (status[key]) { |
There was a problem hiding this comment.
Check the status bool value
| [self setHasPendingDownloads:NO]; | ||
| for (NSString *key in status.allKeys) { | ||
| @synchronized (self) { | ||
| if (status[key]) { |
There was a problem hiding this comment.
Check the status bool value
| @@ -84,6 +93,11 @@ - (void)update { | |||
|
|
|||
| if (![_value isEqual:oldValue]) { | |||
| _hasChanged = YES; | |||
|
|
|||
| // Update _fileURL with new value if it has changed. | |||
| if ([_kind isEqualToString:CT_KIND_FILE]) { | |||
There was a problem hiding this comment.
File needs to be downloaded ad-hoc if the variable is registered after the initial fetch and applyDiffs
| XCTAssertEqualObjects(expValue1, var1.fileValue); | ||
| } | ||
|
|
||
| - (void)removeFiles { |
There was a problem hiding this comment.
The method can be moved to helper and reused
| XCTAssertEqualObjects(expValue, varFromDelegate.value); | ||
| } | ||
|
|
||
| - (void)removeFiles { |
There was a problem hiding this comment.
The method can be moved to helper and reused
| XCTAssertEqualObjects(@1, var1.value); | ||
| } | ||
|
|
||
| - (void)removeFiles { |
There was a problem hiding this comment.
The method can be moved to helper and reused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onVariablesChangedAndNoDownloadsPendingandonceVariablesChangedAndNoDownloadsPending.fileIsReadycallback in CTVarDelegate when file is downloaded.