Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sky Island vampire compatibility #79507

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

SariusSkelrets
Copy link
Contributor

Summary

Mods "Sky Island vampire compatibility"

Purpose of change

You couldn't start as a vampire if using both XE and Sky Island. Now you can.
Even if you did became a vampire, post-third progression depended on very long quests and multiple NPCs, which are impractical in sky island, so I'm fixing that too.

Describe the solution

Add a sky island hobby to start as a vampire, which grants a trait that grants the wan effect at game start (ideally it would just give the effect but I found nothing about giving effects or directly triggering EOCs through hobbies.)
Add a recipe learned by tier 3 vampires when they come back to the island, giving an item that they can use to gain tier 4.
Reaching tier 4 gives two recipes when returning on the island: the item for the fifth tier and the item to unlock blood gift research.

Describe alternatives you've considered

Keeping sky island vampirism gated behind luck and long quests in a game mod that makes long quests almost impossible.

Testing

Spawned on the island with the hobby. Had the wan effect.
Gained tier 3 and came back to the island. Gained tier 4 recipe.
Used tier 4 item, became tier 4 and gained the other two recipes.
Used tier 5 item, became tier 5.
Used blood research item, gained the blood research recipe.

Additional context

Vampires still burn under the sun when on the island, but that will be for another PR.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies EOC: Effects On Condition Anything concerning Effects On Condition Mods: Sky Island Anything about the Sky Island mod json-styled JSON lint passed, label assigned by github actions labels Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Key of Vampiric Knowledge
  • Key of Vampiric Knowledges
  • Superior Vampiric Amplificator
  • Superior Vampiric Amplificators
  • This strange metaphysical artifact will allow you to spend your blood to obtain new blood gifts.\n\nAs per the previous vampiric amplificator, you have to decide to use the crafted item for its effect to apply.
  • This strange metaphysical artifact will push your vampirism to its absolute limit.\n\nAs per the previous vampiric amplificator, you have to decide to use the crafted item for its effect to apply.
  • Vampiric Amplificator
  • Vampiric Amplificators

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Feb 3, 2025
@Maleclypse Maleclypse merged commit 9351cfe into CleverRaven:master Feb 4, 2025
28 checks passed
@SariusSkelrets SariusSkelrets deleted the Sky_island_Vampire branch February 4, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods Issues related to mods or modding Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants