Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove morale penalty from dismemberment #79479

Merged

Conversation

Et-Tu-Brute1234
Copy link
Contributor

@Et-Tu-Brute1234 Et-Tu-Brute1234 commented Feb 1, 2025

Summary

Balance "Removed morale penalties and rare drops from dismemberment"

Purpose of change

Allows dismemberment to remain a solution to keeping acid zombie corpses down for any character regardless of traits. Removing rare drops balances this change.

Describe the solution

There was already an exception to how the morale penalties and rare drops should be handled in the case of dissection. I simply added dismemberment to the list of exceptions.

Describe alternatives you've considered

Reworking acid zombies, or adding a new "careful pulp" mechanic would also have worked.

Testing

Opened a world, killed and dismembered a zombie.

Additional context

@Et-Tu-Brute1234 Et-Tu-Brute1234 changed the title Update activity_handlers.cpp Remove morale penalty from dismemberment Feb 1, 2025
Copy link
Member

@GuardianDll GuardianDll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to astyle your changes
I'm in the middle of joining dismemberment and pulping, but i do not see a problem merging this in the meantime

@github-actions github-actions bot added new contributor Game: Balance Balancing of (existing) in-game features. [C++] Changes (can be) made in C++. Previously named `Code` labels Feb 1, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 1, 2025
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to just make dismemberment into "crappy butchery".

image

image

I noticed you have omitted the "purpose of change" section in your PR summary. In order for this PR to be accepted, I think you need to explain your reasoning in making this change.

Et-Tu-Brute1234 and others added 4 commits February 1, 2025 10:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 1, 2025

I think this has ended up in a really good place

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 2, 2025
@GuardianDll GuardianDll merged commit d875aa6 into CleverRaven:master Feb 3, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants