-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy electronic storage code + small e-storage fixes #79306
base: master
Are you sure you want to change the base?
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
c46106f
to
cd4e1ac
Compare
|
cd4e1ac
to
9f8fa6a
Compare
(continued from above) ERROR : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item.cpp:1826 [put_in] tried to put an item (test_textbook_fabrication) count (1) in a container (test_ebook_reader) that cannot contain it: pocket with type (E_FILE_STORAGE) not found |
item categories for software, files
9f8fa6a
to
809f3e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-requesting reviews from non-collaborators: @bombasticSlacks
Summary
Infrastructure "remove legacy electronic storage code + small e-storage fixes"
Purpose of change
One of many planned follow-ups to #79097
Removes/modifies most code that was made obsolete by that PR.
Describe the solution
Remove code, fix bug; this was part of #79097 but was left out to reduce size.
Part of reworking the legacy content was making e-files and software separate item categories.
Describe alternatives you've considered
Testing
Verified bug was fixed, ran clang-tidy and tests locally.
Additional context
More coming soon