Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
While trying to understand the code, I found some things to improve.
Describe the solution
is_pick_up_inv
toignore_non_container_pocket
and document it.Describe alternatives you've considered
is_pick_up_inv
instead of renaming it. The doc comment would confuse the programmer as to why the parameter has such a weird name.Testing
Additional context
More refactoring is possible, but I plan to change the "Can be stored in" menu. Then the code will change too.