Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clear items in npc_test #79300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

osuphobia
Copy link
Contributor

@osuphobia osuphobia commented Jan 23, 2025

Summary

Bugfixes "clear items in npc_test"

Purpose of change

Fix #74081

Describe the solution

clear items spawned with the NPC to prevent unintended random failure.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added NPC / Factions NPCs, AI, Speech, Factions, Ownership Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 23, 2025
@GuardianDll
Copy link
Member

It looks like it didn't fix the problem

@osuphobia
Copy link
Contributor Author

It looks like it didn't fix the problem

ehmm looks like clear_character will set the position of the NPC to spot( 60, 60, 0 ), so I should tweak this patch a little😵

@osuphobia osuphobia changed the title call clear_character in npc_test clear items in npc_test Jan 23, 2025
@osuphobia osuphobia marked this pull request as draft January 23, 2025 13:17
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 23, 2025
@osuphobia osuphobia closed this Jan 24, 2025
@osuphobia osuphobia reopened this Jan 24, 2025
@osuphobia osuphobia marked this pull request as ready for review January 24, 2025 07:16
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 24, 2025
@osuphobia osuphobia marked this pull request as draft January 24, 2025 08:45
@osuphobia osuphobia marked this pull request as ready for review January 24, 2025 08:45
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. json-styled JSON lint passed, label assigned by github actions NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npc_prefers_guns and npc_uses_guns are failing
2 participants