Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Boann island updates #79284

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jan 21, 2025

Summary

Mods "[Xedra Evolved] Boann island updates"

Purpose of change

Testing a different PR and saw that Boann was wearing a t-shirt and jeans and holding a nailbat. A bit odd for one of the Fair Folk nobility.

Describe the solution

Explicitly define Boann's gear (it was random, hence the nailbat). She's wearing gossamer formal wear (the gown is enchanted to provide protection), a tiara, and has a unique enchanted blade.

Give her super princess hair now that that's an option.

Give her some of the Noble Changeling traits, since that's supposed to represent Fair Folk like her.

Add a small chance of goblin fruit bushes on the island

Change the path leading in from bare rock to gravel

Revamp her tower so it has stained glass windows instead of metal bars with no glass.

Describe alternatives you've considered

Testing

Screenshot 2025-01-16 084313

Screenshot 2025-01-16 084313

Additional context

Might be nice to giver her some retainers (a couple knights, a couple brownies, etc), but that should be another PR

@Standing-Storm Standing-Storm marked this pull request as draft January 21, 2025 21:06
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Melee Melee weapons, tactics, techniques, reach attack Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jan 21, 2025
@github-actions github-actions bot requested a review from Maleclypse January 21, 2025 21:06
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jan 21, 2025
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Soft indoor shoes, suitable for wearing whie drinking liquid light from goblets of unmelting ice and dancing the night away.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 22, 2025
@github-actions github-actions bot added Items: Armor / Clothing Armor and clothing and removed BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 22, 2025
@Standing-Storm Standing-Storm marked this pull request as ready for review January 23, 2025 03:09
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 23, 2025
@Maleclypse Maleclypse merged commit 813d680 into CleverRaven:master Jan 23, 2025
23 of 28 checks passed
@Standing-Storm Standing-Storm deleted the boann-gear branch January 23, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mechanics: Enchantments / Spells Enchantments and spells Melee Melee weapons, tactics, techniques, reach attack Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants