-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Aftershock] Introduce Combat EVA suits to the spawn groups. Small audit to EVA suit spawning. #79283
Merged
Maleclypse
merged 10 commits into
CleverRaven:master
from
QuillInkwell:aftershock_wintersuit_spawn_adjustments
Jan 22, 2025
Merged
[Aftershock] Introduce Combat EVA suits to the spawn groups. Small audit to EVA suit spawning. #79283
Maleclypse
merged 10 commits into
CleverRaven:master
from
QuillInkwell:aftershock_wintersuit_spawn_adjustments
Jan 22, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s tail compatible opps
…r PR or maybe they just don't make ones for mutants.
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Spawn
Creatures, items, vehicles, locations appearing on map
Mods: Aftershock
Anything to do with the Aftershock mod
Items: Armor / Clothing
Armor and clothing
astyled
astyled PR, label is assigned by github actions
labels
Jan 21, 2025
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
labels
Jan 21, 2025
Mutant EVA suit Should for tall or small mutant |
For sure if we add those traits to Genetech I can revive the discarded json from this PR and modify it to fit that niche. Same for if we add traits like Digitigrade legs. But those aren't Genetech traits currently so I'll hold off and add that content only once I know it's for sure needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Items: Armor / Clothing
Armor and clothing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Map / Mapgen
Overmap, Mapgen, Map extras, Map display
Mods: Aftershock
Anything to do with the Aftershock mod
Mods
Issues related to mods or modding
Spawn
Creatures, items, vehicles, locations appearing on map
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Aftershock] Combat Suits can now be obtained and update wintersuit itemgroups."
Purpose of change
There is a combat version of the Cryosuit that is just not used anywhere but one single starting profession. It would be nice to be able to buy or loot this suit from the Exo-Planet so players can also make the choice between wearing armor or longer battery life on their suits.
Since the standard EVA gear is now tail friendly we can remove the mutant EVA gear group.
In my last playthrough I noted no shortage of EVA gear. I became flush with batteries almost immediately.
Describe the solution
The combat EVA suit can now be bought from the Port Augustmoon trader. It also spawns in the Enforcer station changing room. As well as in UICA military lockers and thus can be purchased from the UICA Quartermaster.
UICA ground soldiers now wear combat EVA suits and frontier masks. (They had no EVA gear on before).
The Mutant EVA gear group has been deleted and the Gene Clinic now spawns just standard EVA gear in it's first floor closet.
Spawning of EVA gear in civilian lockers has been nerfed by 20%. (From 50% per locker to 30% per locker. (Probably still too high?)
Describe alternatives you've considered
I did originally make mutant friendly versions of all EVA gear but that was fixed already by making most EVA gear soft. So I was able to just remove all that.
I did consider leaving the Magellen Mutant suit in but opted against it. I am okay with mutants having some draw bakcs in terms of the gear that is available to them. And there doesn't strictly seem to be any reason for this gear to be mutant compatible. (Maybe there just aren't enough genetically augmented humans to justify manufacturing a mutant friendly version?)
Testing
Lockers spawn suits much less aggressively.
UICA soldiers are wearing their gear and did not drop it on the ground.
Augustmoon Outfitter was selling the combat suit.
Police Station spawned the combat suit.
UICA lockers spawned with combat suits.
Additional context