Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Aftershock] Introduce Combat EVA suits to the spawn groups. Small audit to EVA suit spawning. #79283

Conversation

QuillInkwell
Copy link
Contributor

@QuillInkwell QuillInkwell commented Jan 21, 2025

Summary

Mods "[Aftershock] Combat Suits can now be obtained and update wintersuit itemgroups."

Purpose of change

There is a combat version of the Cryosuit that is just not used anywhere but one single starting profession. It would be nice to be able to buy or loot this suit from the Exo-Planet so players can also make the choice between wearing armor or longer battery life on their suits.

Since the standard EVA gear is now tail friendly we can remove the mutant EVA gear group.

In my last playthrough I noted no shortage of EVA gear. I became flush with batteries almost immediately.

Describe the solution

The combat EVA suit can now be bought from the Port Augustmoon trader. It also spawns in the Enforcer station changing room. As well as in UICA military lockers and thus can be purchased from the UICA Quartermaster.

UICA ground soldiers now wear combat EVA suits and frontier masks. (They had no EVA gear on before).

The Mutant EVA gear group has been deleted and the Gene Clinic now spawns just standard EVA gear in it's first floor closet.

Spawning of EVA gear in civilian lockers has been nerfed by 20%. (From 50% per locker to 30% per locker. (Probably still too high?)

Describe alternatives you've considered

I did originally make mutant friendly versions of all EVA gear but that was fixed already by making most EVA gear soft. So I was able to just remove all that.

I did consider leaving the Magellen Mutant suit in but opted against it. I am okay with mutants having some draw bakcs in terms of the gear that is available to them. And there doesn't strictly seem to be any reason for this gear to be mutant compatible. (Maybe there just aren't enough genetically augmented humans to justify manufacturing a mutant friendly version?)

Testing

Lockers spawn suits much less aggressively.
UICA soldiers are wearing their gear and did not drop it on the ground.
Augustmoon Outfitter was selling the combat suit.
Police Station spawned the combat suit.
UICA lockers spawned with combat suits.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Map / Mapgen Overmap, Mapgen, Map extras, Map display Spawn Creatures, items, vehicles, locations appearing on map Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions labels Jan 21, 2025
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 21, 2025
@Bone-blood-moss
Copy link

Mutant EVA suit Should for tall or small mutant

@QuillInkwell
Copy link
Contributor Author

Mutant EVA suit Should for tall or small mutant

For sure if we add those traits to Genetech I can revive the discarded json from this PR and modify it to fit that niche. Same for if we add traits like Digitigrade legs. But those aren't Genetech traits currently so I'll hold off and add that content only once I know it's for sure needed.

@Maleclypse Maleclypse merged commit eb012c4 into CleverRaven:master Jan 22, 2025
24 of 29 checks passed
@QuillInkwell QuillInkwell deleted the aftershock_wintersuit_spawn_adjustments branch January 22, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants