Vested Survivor Jumpsuits And Other Minor Changes

[Kantonine]

Summary

Balance "Gives ballistic vests to survivor jumpsuits, changes names slightly, and one warmth change"

Purpose of change

Part of #74188, to try and bring the survivor items a bit more down to earth, as well as ensuring parity with other items.

Describe the solution

Adds 3.3mm of ballistic kevlar to the midweight survivor jumpsuit, heavy jumpsuit, and the firesuit. Also adds mild chainmail to the heavy survivor jumpsuit, renames the suits to survivor jumpsuits instead of kevlar jumpsuits, and makes the survivor suit slightly less warm

Describe alternatives you've considered

I did debate on whether i should leave the steel plating for the heavy jumpsuit as sheet steel, and not chainmailifying it. If there's a good reason to revert it back, i'll consider it.

Testing

Additional context

Doesn't touch any of the crafting recipes, as I lose braincells trying to change the crafting recipes without breaking or otherwise making the recipes unbalanced.

[Daved27hundred]

maybe "mercenary jumpsuit" instead, so it's inline with the other Mercenary armor we have? In my eyes it rolls off the tongue better than survivor jumpsuit.

[Kantonine]

maybe "mercenary jumpsuit" instead, so it's inline with the other Mercenary armor we have? In my eyes it rolls off the tongue better than survivor jumpsuit.

Hmmmm, that could work, tho it might be a bit odd with the already pre-existing mercenary coat, and the survivor trenchcoat and duster.

[IdleSol]

1. You have an error for the fire suit:

        "covers": [ "torso" ],
        "coverage": 100,
        "encumbrance": [ 24, 24 ]
      },
      {
        "material": [
          { "type": "nomex", "covered_by_mat": 100, "thickness": 2 },
          { "type": "kevlar", "covered_by_mat": 100, "thickness": 1.3 },
          { "type": "nylon", "covered_by_mat": 100, "thickness": 1.0 }
        ],
        "covers": [ "torso", "leg_l", "leg_r", "arm_l", "arm_r" ],

Torso in two places.

2. I would add a "cover_vitals" parameter for suits. (Reduces damage from critical hits)

[GuardianDll]

warnings for type hsurvivor_jumpsuit:
for material kevlar_layered, 3.300000 isn't a valid multiple of the thickness the underlying material comes in: 4.400000.```

[Kantonine]

1. You have an error for the fire suit:

        "covers": [ "torso" ],
        "coverage": 100,
        "encumbrance": [ 24, 24 ]
      },
      {
        "material": [
          { "type": "nomex", "covered_by_mat": 100, "thickness": 2 },
          { "type": "kevlar", "covered_by_mat": 100, "thickness": 1.3 },
          { "type": "nylon", "covered_by_mat": 100, "thickness": 1.0 }
        ],
        "covers": [ "torso", "leg_l", "leg_r", "arm_l", "arm_r" ],

Torso in two places.

2. I would add a "cover_vitals" parameter for suits. (Reduces damage from critical hits)

Thanks for the heads up! I'll add that in, how does it work, is it a percentage reduction in damage from crits, or crit reduction chance for attacks made against you?

[Kantonine]

warnings for type hsurvivor_jumpsuit:
for material kevlar_layered, 3.300000 isn't a valid multiple of the thickness the underlying material comes in: 4.400000.```

I noticed that, but i don't want to end up making it thicker than it needs to be, i tried to make the ballistic kevlar layer the same as the kevlar vest, which is 3.3mm, is it a issue with the defined thickness of the suit itself, density, or what?

[GuardianDll]

Need to use "ignore_sheet_thickness": true in this case

[Kantonine]

Need to use "ignore_sheet_thickness": true in this case

Where does that bit go? Thnx in advance

[Maddremor]

Why are you naming the jumpsuits to have the "survivor" prefix?

[esotericist]

drop the renaming changes that include putting 'survivor' there. it's pointless, has an unnecessary impact on descriptiveness, and generally a bunch of us have been happy seeing its presence eroded.

[kevingranade]

This has the same problem as
#78039
I'm not aware of any existing examples of plate carriers being incorporated into larger articles of clothing like this. Other articles of clothing get adjusted to go around plate carriers.

[IdleSol]

It's most likely a translation problem. What plates are we talking about? All I see is chain mail. (lc_steel_chain)

how does it work

Cataclysm-DDA/doc/JSON/JSON_INFO.md

Line 3672 in 18f379b

"cover_vitals": 10, // What percentage of critical hit damage is mitigated

I have no idea.

Cataclysm-DDA/src/creature.h

Lines 444 to 445 in 18f379b

	// Converts the "cover_vitals" protection on the specified body part into
	// a modifier (between 0 and 1) that would be applied to incoming critical damage

[Kantonine]

Alright, I'll revert the prefix change (and it might be carried over to when the other items get changed, or it all gets changed to mercenary if it's suitable.).

This has the same problem as #78039 I'm not aware of any existing examples of plate carriers being incorporated into larger articles of clothing like this. Other articles of clothing get adjusted to go around plate carriers.

I'm not having plates for the suits, that stays exclusive to the plate carriers (and mercenary coat) the chainmail is for additional protection for the arms and legs. I am not using the plate carriers, but rather the plate-less kevlar vest (https://cdda-guide.nornagon.net/item/kevlar), the same one used for the mercenary body armor. I can see that there might be more lee-way with the mercenary body armor, seeing that it's only a combat shirt, kevlar vest, and kevlar arm protection all stitched together, making it quite a bit thinner overall compared to the jumpsuits.

[tenehea]

If the player wanted to wear chainmail with their kevlar jumpsuit, they'd make a kevlar jumpsuit and a suit of chainmail..

[GuardianDll]

Where does that bit go?

like this

{ "type": "kevlar_layered", "thickness": 1.1, "ignore_sheet_thickness": true }

[kevingranade]

Plate, chain, whatever, who is attaching metal armor sections to otherwise regular clothes? Clothes are clothes and armor is armor.

[tenehea]

Plate, chain, whatever, who is attaching metal armor sections to otherwise regular clothes? Clothes are clothes and armor is armor.

?

All armor is clothing but not all clothing is armor. A coat of plates, for example, is clothing (a cloth tunic) with plates riveted on top.

[Kantonine]

Plate, chain, whatever, who is attaching metal armor sections to otherwise regular clothes? Clothes are clothes and armor is armor.

Our CDDA survivors/NPCs sure do:
https://cdda-guide.nornagon.net/item/jeans_mod
https://cdda-guide.nornagon.net/item/vest_jean_mod
https://cdda-guide.nornagon.net/item/jacket_jean_mod
https://cdda-guide.nornagon.net/item/vest_leather_mod
https://cdda-guide.nornagon.net/item/jacket_leather_mod
https://cdda-guide.nornagon.net/item/gloves_fingerless_mod