Loot sorting: stop moving crafts in progress #79279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent sorting activity from moving items that somebody works on fixes CleverRaven#74170
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent sorting activity from moving items that somebody works on
Summary
Bugfixes "Prevent sorting activity from moving items that somebody works on"
Purpose of change
Items that somebody works on should not be moved because it interrupts crafting. Fixes #74170
Describe the solution
Collect all items that are being crafted and don't move them. Skip items with "activity_var" (for example, disassembly in progres)
Describe alternatives you've considered
Testing
Autotests and manual testing.
Additional context
Set the unsorted loot zone on the workbench, set "Loot: other" somewhere else. Ask NPC to sort items and start crafting something on the workbench. Same with disassembly