fix practice recipes giving progress item

[marilynias]

Summary

bugfixes "Allow nested recipes to delete the item, if they dont yield any results."

Purpose of change

Some practice recipes were giving in-progress items even though they didn't require components and yielded no items.
fix #79249
fix #75226

Describe the solution

Check if they require and produce no items, not if they are in the practice category.

Testing

Practice of those recipes now leaves no item if canceled. Normal recipe still leaves in-progress item.

Additional context

Practice recipes should be the only ones affected, but if some other recipes don't require and yield any items they are probably safe to delete aswell.

[Karol1223]

While this fixes the issue, it just sweeps the actual problem under the rug.

These recipes should be allowed to remain as nested recipes. The underlying problem should be fixed in C++, not hidden. You didn't "assign actual categories" to them, you just unnested them.

[marilynias]

While this fixes the issue, it just sweeps the actual problem under the rug.

These recipes should be allowed to remain as nested recipes. The underlying problem should be fixed in C++, not hidden. You didn't "assign actual categories" to them, you just unnested them.

Ah okay I misunderstood the categories, will fix in cpp

[marilynias]

ready for re-review

[Karol1223]

ready for re-review

For the record, since I feel like you're waiting for my review - you shouldn't. I know what gets accepted, I know the development direction, but I do NOT know C++. I could not tell you whether something you wrote fixes the bug or sends scam emails if I wanted to. You're gonna want someone who knows how to read for this one.

[marilynias]

ready for re-review

For the record, since I feel like you're waiting for my review - you shouldn't. I know what gets accepted, I know the development direction, but I do NOT know C++. I could not tell you whether something you wrote fixes the bug or sends scam emails if I wanted to. You're gonna want someone who knows how to read for this one.

not entirely sure how the review system works, can you take back your requested changes, since they dont apply anymore? Or how do you change reviewer?