Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Can always repair simple parts on helicopters, inside or outside"
Purpose of change
vehicle::would_repair_prevent_flyable is a bit weird. For simple parts it checks if the part is outside. For some reason, a simple part is no longer simple if it's on the outside. But then why have the flag at all?
It doesn't check the aircraft mechanic proficiency at all for such simple parts(!). Which means that someone with the (debug only) proficiency could still not repair a simple part, by 'virtue' of the part being on the outside of the helicopter.
Describe the solution
Simple:
Simple parts are always simple.
Align the functionality of these two flags with their actually documented effect.
The debug proficiency remains as permissive as possible (although we still don't bother evaluating it if we're dealing with a simple part).
Describe alternatives you've considered
-Introduce more finely grained flags. SIMPLE_PART_INSIDE, SIMPLE_PART_OUTSIDE, etc. Needless.
-Change the order of evaluation so the proficiency is checked first. But then the weirdness with simple parts would remain
Testing
Did not personally test. Pretty simple code change IMO.
Testing suggestions for mergers:
Add SIMPLE_PART to one of the parts of the 'wings' of the apache helicopter. Try to repair, notice failure.
Apply patch. Try to repair, notice success.
Additional context