Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font mistake on zh_CN and zh_TW #79228

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Fix font mistake on zh_CN and zh_TW #79228

merged 2 commits into from
Jan 18, 2025

Conversation

EliadOArias
Copy link
Contributor

@EliadOArias EliadOArias commented Jan 18, 2025 •
edited
Loading

…_HANS

Summary

Bugfixes "Fix font mistake on zh_CN and zh_TW"

Purpose of change

Fix #78837.
Developer mistake zh_CN and zh_TW when get font ranges. This lang zh_TW use common zh_CN glyphs, lang zh_CN use common zh_TW glyphs.

Describe the solution

Swap AddGlyphRangesFromCLDRForZH_HANS and AddGlyphRangesFromCLDRForZH_HANT.

Describe alternatives you've considered

None

Testing

Test zh_CN font range: OK
e17880f3208f64ba92b3b91076052277
Test zh_TW font range: OK
c0ff8c8d8f557dddb99ef5ff23e93f88

Additional context

This is an easy fix.

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jan 18, 2025
@EliadOArias EliadOArias mentioned this pull request Jan 18, 2025
Closed
@SurFlurer
Copy link
Contributor

SurFlurer commented Jan 18, 2025 •
edited
Loading

I think the better approach is to rename the functions to minimize misunderstanding?

Edit: nevermind

db48x
db48x approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@db48x db48x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking that down!

@akrieger akrieger merged commit 018223c into CleverRaven:master Jan 18, 2025
27 of 28 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@db48x db48x db48x approved these changes

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cata ImGui can't get font size of zh_CN correctly
4 participants
@EliadOArias @SurFlurer @db48x @akrieger