Expand NULL_ID() usage #79190
Merged
Expand NULL_ID() usage #79190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Some code was using a debug limb sub body part as a null id instead of the already existing NULL_ID, me no likey
Describe the solution
Add attack_vector_id::NULL_ID()
Use sub_bodypart_str_id::NULL_ID() rather than sub_bodypart_str_id( "sub_limb_debug" ). I did consider changing the null id to sub_limb_debug or adding migration for one id to the other but as far as I can tell this should be fine.
Use bodypart_str_id::NULL_ID() when initialising and comparing bodypart_id (the int_id)
Describe alternatives you've considered
Bodyparts use externs and alot of just raw string initialising that also wants cleaning up into static consts
Testing
Game compiles
Additional context