Mics EoC edits #79169
Merged
Mics EoC edits #79169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Auto-requesting reviews from non-collaborators: @bombasticSlacks @Standing-Storm
|
Very neat! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Nicer syntax
Describe the solution
If possible,
run_eocsare replaced with if-else bitsu_lose_effect can accept arrays of effects to be removed; also
target_partfield support value ALL, which would remove effect from all limbsProfessions now can invoke EoC directly, without events and stuff; convicted asassin profession uses it now
Testing
Booted up the game, loaded few scenario, including prison assasin, EoC booted up as expected
removing effect works also