Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typified a-f #79155

Merged
merged 1 commit into from
Jan 15, 2025
Merged

typified a-f #79155

merged 1 commit into from
Jan 15, 2025

Conversation

PatrikLundell
Copy link
Contributor

Summary

None

Purpose of change

Replace usage of untyped coordinates with typed ones. This time files named a-f (primarily).

Describe the solution

Replace usage of untyped coordinate operations with corresponding typed ones, creating the typed ones if needed, and removal of orphaned untyped operations. Go through implementations to switch to typed coordinates.
There should be no functional changes.

Describe alternatives you've considered

Testing

Load save, walk up ramp, jump into car, drive through hay bales, run over zombie corpse with inventory, run into but fail to run over turkey, get killed when running into stationary vehicle. Nothing odd seen.

Additional context

The UI stuff remains untyped. The coordinates should probably be in a screen specific coordinate system that doesn't exist currently.

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Bionics CBM (Compact Bionic Modules) Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Code: Tests Measurement, self-control, statistics, balancing. [C++] Changes (can be) made in C++. Previously named `Code` Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 14, 2025
@Maleclypse Maleclypse merged commit 7a1d021 into CleverRaven:master Jan 15, 2025
29 checks passed
@PatrikLundell PatrikLundell deleted the typify branch January 15, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Bionics CBM (Compact Bionic Modules) [C++] Changes (can be) made in C++. Previously named `Code` Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants