Bump minimum supported macOS version to 10.15 (macOS Catalina) #79098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1f8621b to
c907b5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructure "Bump minimum supported macOS version to 10.15 (macOS Catalina)"
Purpose of change
Is a requirement for #79092 (macOS 10.13 does not have
<filesystem>header despite supporting C++17. [ref])At the time of writing macOS 10.13 (macOS High Sierra) has a market share of 0.92%, and macOS 10.15 is at 96.35% (ref: https://gs.statcounter.com/os-version-market-share/macos/desktop/worldwide)
Dropping support for 10.13 does not sound unreasonable.
Describe the solution
Update the
-mmacosx-version-minflagUpdate the docs.
Describe alternatives you've considered
<filesystem>shim specifically for old macOS...Testing
Added a random
std::filesystem::pathusage to one of cpp files, fed it to the CI, CI didn't seem to mind (link)Additional context
The way we're reporting min supported xcode seems to be fraudulent, since there's no clear correspondence between mac os version (incl.
-mmacosx-version-min) and xcode version. The xcode running on CI is version 15.2 for example, judging by the logs. Perhaps it would be better to remove that field completely so as not to confuse people?.. Idk, this is a tangent anyway...If someone who understands Apple ecosystem could double-check my xcode selection that would be appreciated.