Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale spell window to spell list and terminal size #78883

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

Kilvoctu
Copy link
Contributor

@Kilvoctu Kilvoctu commented Jan 1, 2025

Summary

SUMMARY: Interface "Scale spell window to spell list and terminal size"

Purpose of change

Reduce amount of scrolling when screen space allows
Improve usability on small terminal size
Fixes #78802

(I accidentally screwed up #78871 by merging a different branch into it, instead of the other way around, so I'm remaking the PR)

Describe the solution

Give the spells window more space to show spell descriptions by default.
As more spells populate the list, the window's vertical size increases, up to 90%.
For smaller terminal sizes, the spells window will shrink as needed to fit.

Describe alternatives you've considered

Use the entire vertical space of the screen if needed
Not increasing height to accomodate description

Testing

Game compiles and loads
Create character and debug in spells
Test varying spell list amounts at multiple terminal sizes
Scroll through spell tabs

Additional context

Before, fresh install build 76c2d10
Maximum terminal
76c2d10 - max terminal

After
Max terminal
Screenshot 2024-12-31 031815
With many spells
Screenshot 2024-12-31 031942
With one spell
Screenshot 2024-12-31 032136


Before
Minimum terminal
76c2d10 - min terminal

After
Min terminal
Screenshot 2024-12-31 031821
With one spell
Screenshot 2024-12-31 031855

Co-Authored-By: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Jan 1, 2025
@github-actions github-actions bot requested a review from KorGgenT January 1, 2025 04:00
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jan 1, 2025
@Maleclypse Maleclypse merged commit 5122d22 into CleverRaven:master Jan 1, 2025
22 of 27 checks passed
@Kilvoctu Kilvoctu deleted the fix_scale_magic_ui2 branch January 1, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supernatural ability/spell menu window doesn't scale/expand vertically (and can't be resized)
2 participants