Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow military NVGs to attach to combat exoskeleton helmets #76018

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

Regilith
Copy link
Contributor

@Regilith Regilith commented Aug 28, 2024

Summary

Features "Allow military night vision goggles to attach to combat exoskeleton head armors"

Purpose of change

Implements #75978

Military night vision goggles were recently made to only be usable when attached to military helmets with the proper mounts. Considering exoskeletons were developed by the military and made to be modular, it seems like an oversight that the suits would not be able to utilize this technology to allow soldiers to see in the dark, without relying on CBMs.

Describe the solution

Added MODULE_HOLDER to the base exoskeleton, copy/pasted the "HELMET_FRONT_ATTACHMENT" pocket from the army helmet to the heavy exoskeleton head armor, which all other exoskeleton helmets "copy-from".

Describe alternatives you've considered

Create a proprietary solution for the exoskeletons, make a rare drop somewhere. Seems like an unnecessary duplication of code though, and would likely necessitate the creation of a unique flag just for that item. Allowing players to use NVGs with exoskeleton armor doesn't seem like something that needs to be earned, since exoskeletons are locked behind one of the toughest bosses in the game already.

Make the survivor custom-create a bracket to allow the helmet to accept NVGs. This doesn't really help explain the issue as to why the military would not make the exoskeletons have NVG functionality in the first place.

Make the NVG effect built-in to the exoskeleton itself, but the other power armors already do that, and I think to better fit the flavor of the combat exoskeleton we should lean on the modular philosophy of the exoskeleton and use pre-existing NVGs.

Testing

Copy/pasted the edited json files into a freshly-installed latest experimental. Inserted all three military NVGs into four different exoskeleton helmet armors, NVG effect was applied each time.

Additional context

image

image

I also considered adding flavor text to all the helmets, mentioning the addition of the new pocket. Since it did not mention the pre-existing pocket for a headlamp though, and to keep this PR small, I opted not to.

Allows NVGs to function while in a pocket within a pocket
other helmets use copy-from to inherit the pocket
@Regilith Regilith changed the title Allow military NVGs to attach to exoskeleton helmets Allow military NVGs to attach to combat exoskeleton helmets Aug 28, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing <Enhancement / Feature> New features, or enhancements on existing labels Aug 28, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 28, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 28, 2024
@Maleclypse Maleclypse merged commit a1f2f69 into CleverRaven:master Aug 30, 2024
24 checks passed
@Regilith Regilith deleted the combat-exoskeleton-NVG branch August 30, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants