Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning some unused IDs #75926

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Pruning some unused IDs #75926

merged 2 commits into from
Aug 26, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

Removing some unused IDs, or actually using them

Describe the solution

Affected IDs:

  • mon_zandcralwer - removed from TropiCata on the notion of not fitting there, removed from DesertMod on the notion that the mod is obsoleted anyway
  • mon_spinosaurus_bio_op - now replaces mon_spinosaurus in the DinoMod lab group, similar to how the tyrannosaurus is handled in that mongroup. @LyleSY please confirm that this is applicable, or tell me where else to put it
  • feral_weapon_feral_m9 - removed, as it appears the monster that used it no longer wields that weapon. I believe Guardian changed the feral security guard in the past, and I think that's the monster that used it when I first added this attack

Describe alternatives you've considered

There's a bunch more unused content in DesertMod, but I feel bad removing more of it because a part of me still wants to revive that mod. Since it's obsoleted the tests don't run on it, so it can stay for now

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Desert Region Anything relating to the Desert Region mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 24, 2024
@Maleclypse Maleclypse merged commit 18b13f1 into CleverRaven:master Aug 26, 2024
25 of 26 checks passed
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 26, 2024
@Karol1223 Karol1223 deleted the unused-ids branch August 26, 2024 15:28
Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Desert Region Anything relating to the Desert Region mod Mods: Dinomod Anything to do with the Dinoclysm mod (DinoMod) Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants