-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra] Inventor: (Re)Add Dimensional Research #75916
Conversation
… to copy dozens of EOCs now
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Ok it's too late for me to review this tonight and there is a conflict that I can't resolve in the browser. I'll try and review this tomorrow. :) Thanks for working on this! |
OK I've reviewed this and I absolutely love it! Let me know if you need me to rebase this for you to resolve the conflict. |
I believe I've resolved the merge conflict. Pull request should be ready to go |
* Return of the Vancian Bill * Add back dimension research * Add ERN Recorder as a non-Hub method for getting an NRE recorder * Add netherium warp grenade and code to allow dropped items to cast spells * Add dimensional smoothing device. Unfortunately portal storms don't really work: CleverRaven#74774 * add teleporter crafting recipe * Remove ERN Recorder and just let inventors make NRE recorder. No need to copy dozens of EOCs now * Why's a lint? * Remove left over debug print * Clean up code * Fix field chance * Nerf vancian bill a bit * Add teleporter to warp grenade recipe * another random thing I missed * spelling * Obey rules on how to write null * Learn more about c++ references * Make double space * rerun tests pt.1 * rerun tests pt.2
Summary
Mods "[Xedra] Inventor: (Re)Add Dimensional Research"
Purpose of change
I like the inventor class. Add some new goodies and other related recipes. Also have some more dimensional research ideas later on.
Describe the solution
Adds an NRE recorder crafting recipe to tier 3 energy research.
Adds the dimensional research path from tier 3 energy. Research requires nre readings
Code Changes:
Allows dropped items to cast spells. These spells are targeted on the dropped item itself. Used in order to allow the netherium grenade to cast a spell as its 'detonation' action. Otherwise the game would just instantly crash.
Describe alternatives you've considered
Add even more things
Testing
Tested that the new items and recipes are acquirable with research
Tested that the vanacian bill kills things
Tested that the netherium warp grenade REALLY kills things
Tested that the Netherium-Reality Smoothing Device closes portals.
has an error. Using it just causes several tripoint errors for a while. Presumably whenever that is fixes this will also be fixed
Code:
Used the netherium warp grenade as a testing base, since it calls several sub spells that perform different actions. Largely confirmed that item spells work, they are targeted correctly on the dropped item, etc.
Additional context
This gives me ideas for an inventor fast travel tool