Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 (monocrystalline) panels to rooftop solar #75431

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ehughsbaird
Copy link
Contributor

Summary

Content "v2 solar panels now spawn in the world more frequently"

Purpose of change

#75227 (comment)

Monosilicon panels don't appear anywhere but on a car. From data on solar added in Massachusetts and monosilicon panel production as a percent of solar production, we can get some numbers for how frequently they should occur.

Year Solar Added (MW) Monosilicon (%) Added Monosilicon (MW)
2011 42.65 25 10.66
2012 134.5 25 33.63
2013 226.94 25 56.74
2014 269.11 25 67.28
2015 286.53 25 71.63
2016 394 25 98.5
2017 571 35 199.85
2018 370 45 166.5
2019 237 65 154.05
Total 2531.73 - 858.83

858.83/2531.73 = 34% high-efficiency monosilicon panels

Production Percent from https://www.ise.fraunhofer.de/content/dam/ise/de/documents/publications/studies/Photovoltaics-Report.pdf
Solar Added from https://www.mass.gov/info-details/renewable-energy-snapshot#installed-solar-capacity-in-massachusetts-

Describe the solution

Add v2 solar panel nests, and make them spawn at the places the other solar nests spawn with 20% chance. 20% is fairly stingy, but the data to get a rate is pretty terrible.

Testing

Teleport around to roofs. Find monocrystalline panels.

The only place v2 panels spawn is on a rare vehicle. This is not the
only place monosilicon panels are found in the real world.

Per some stats I found on monosilicon solar panel usage:

Table for later commit:
Year  |  Solar Added (MW) | Monosilicon (%) | Added Monosilicon (MW)
------|-------------------|-----------------|-----------------------
2011  |   42.65           | 25              |  10.66
2012  |  134.50           | 25              |  33.63
2013  |  226.94           | 25              |  56.74
2014  |  269.11           | 25              |  67.28
2015  |  286.53           | 25              |  71.63
2016  |  394,00           | 25              |  98.50
2017  |  571.00           | 35              | 199.85
2018  |  370.00           | 45              | 166.50
2019  |  237.00           | 65              | 154.05
Total | 2531.73           | -               | 858.83
858.83/2531.73 = 34% high-efficiency monosilicon panels

Solar added is how much solar was added in Massachusetts, and
Monosilicon % is the percent of panels produced that were monosilicon
panels.

Added from:
https://www.mass.gov/info-details/renewable-energy-snapshot#installed-solar-capacity-in-massachusetts-
Production from:
https://www.ise.fraunhofer.de/content/dam/ise/de/documents/publications/studies/Photovoltaics-Report.pdf

Cut down to 20% to account for how terrible the data is. Because
monosilicon is making up an increasing amount of solar production, this
is probably an overadjustment.
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 3, 2024
@Maleclypse Maleclypse merged commit 8e814cc into CleverRaven:master Aug 13, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants