Set owner of disassembly result #75411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the owner for items produced by disassembly to the character performing the disassembly. Prevents the following situation that could happen before: 1. Have an auto-pickup rule for "m:gold", and config option "Auto pickup owned items"=false, so that everything gold is picked up unless it's already yours. 2. Disassemble some gold item, for example "gold watch" 3. Disassembly results are placed somewhere adjacent, including some gold. 4. Move one step, which triggers autopickup 5. Auto-pickup rule from step 1 triggers, and picks up the gold from step 3 This commit instead makes it so that step 5 will not auto-pickup the disassembled gold. Instead, it will stay put just like if you had dropped it there.
d37a0ec to
1591eb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Set owner of disassembly result"
Purpose of change
Sets the owner for items produced by disassembly to the character performing the disassembly.
Describe the solution
Prevents the following situation that could happen before:
This commit instead makes it so that step 5 will not auto-pickup the disassembled gold. Instead, it will stay put just like if you had dropped it there.
Describe alternatives you've considered
Could have instead used
act_item.set_owner( dis_item.get_owner() ), but that's slightly longer and not as explicit.Testing
Performed the steps above. The disassembled gold is no longer auto-picked up.
Additional context