-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect migration #72594
Fix incorrect migration #72594
Conversation
CI failed - unrelated build error: "no matching function for call to 'write_var_value'". Did someone check in and merge code that fails to build? |
It was two PRs being merged at once that didn't account for each other, it's fixed on master now if you want to rebase. |
Whoops sorry I meant to double check those before I put the PR up, writing the migration was really messing with my head |
Can't run tests:
possibly broken by #72261. Ping: @tmqCypher |
Summary
None
Purpose of change
Fixes #72583
#72431 removed some oter_id's, but made a couple of mistakes when writing a migration
Describe the solution
Testing
Loaded my save - no more errors from overmap::unserialize(const JsonObject&)] Loaded invalid oter_id
Additional context
I am still getting this error in my save:
The log does contain messages about successful migrations from dirt_road_3way_east to rural_road_nsw.
It appears something in C++ might be trying to read a save file before it is migrated - out of scope for this PR - will debug and report separately