Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow spawning items with flags #70168

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Conversation

Ramza13
Copy link
Contributor

@Ramza13 Ramza13 commented Dec 12, 2023

Summary

None

Purpose of change

Fix #69889

Describe the solution

Describe alternatives you've considered

Testing

Used this json

    "type": "effect_on_condition",
    "id": "TEST",
    "effect": { "u_spawn_item": "personal_gobag", "flags":["FIT"] }
  },
  {
    "type": "effect_on_condition",
    "id": "TEST2",
    "effect": { "u_spawn_item": "personal_gobag" }
  }

Additional context

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs <Bugfix> This is a fix for a bug (or closes open issue) astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Dec 12, 2023
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Dec 12, 2023
src/npctalk.cpp Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the astyled astyled PR, label is assigned by github actions label Dec 13, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Dec 13, 2023
@Maleclypse Maleclypse merged commit 8554ba5 into CleverRaven:master Dec 14, 2023
19 of 25 checks passed
gkarfakis19 pushed a commit to gkarfakis19/Cataclysm-DDA that referenced this pull request Dec 14, 2023
* First

* Update npctalk.cpp

* Update npctalk.cpp

* Update src/npctalk.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Ramza13 Ramza13 deleted the spawn-flags branch December 15, 2023 00:09
Maleclypse pushed a commit that referenced this pull request Dec 20, 2023
* Initial commit. Infrastracture.

* monster stash

* first attempt at pelagic vs ocean shore creatures

* Proper handling of ocean vs pelagic.

* added a bunch of fish (JSON linted)

* added a bunch of fish (json linted, and fixed)

* Proper handling of ocean vs pelagic + added a bunch of fish.

* Update player_activity.cpp

* Small eoc doc fixes

* Invalidate non-adjacent containers for ALL and DRAGGED (#70172)

This also changes it to not update the container_base_loc's position for ALL and DRAGGED, which made it so pressing X would exit out to a 1-9 location instead of ALL or DRAGGED

Co-authored-by: andrei <68240139+andrei8l@users.noreply.github.com>

* Allow spawning items with flags (#70168)

* First

* Update npctalk.cpp

* Update npctalk.cpp

* Update src/npctalk.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Sky Island] Teleporting items back home (#70200)

* Update EOCs.json

* Update EOCs.json

* Update EOCs.json

* Update EOCs.json

* Update EOCs.json

* Add ```gains_proficiency``` event (#70194)

* create gains_proficiency event

* add event trigger

* Update EFFECT_ON_CONDITION.md

* updated memorial test

* retrigger checks

* [MoM] Add ability for pyrokinetics to cauterize their wounds (#70132)

* Initial commit

* Bleeding that's too heavy cannot be stopped

* Add infection chance

* Add missing types

* Fix infection intensity

* Fix practice recipe

* Reduce capacity of test battery a bit

The value being this large resulted in an integer overflow in
pocket_data::max_contains_volume(). Reduce it until there's no more
integer overflow.

* Proper handling of ocean vs pelagic + added a bunch of fish.

* reversed gitignore accidental change

* reversed gitignore accidental change

* shark rebalance

* Update data/json/monsters/fish.json

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>

* Update data/json/monsters/fish.json

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>

* Update data/json/monsters/fish.json

Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>

* small changes to resolve issues

* small changes to resolve issues

* Update wilderness.json to fix bass typo

* Update fish.json

* Update data/json/monsters/fish.json

Co-authored-by: Karol1223 <68503002+Karol1223@users.noreply.github.com>

* removed roe names

---------

Co-authored-by: Ramza13 <52087122+Ramza13@users.noreply.github.com>
Co-authored-by: Anton Simakov <67688115+GuardianDll@users.noreply.github.com>
Co-authored-by: Kamayana <pigbuster@gmail.com>
Co-authored-by: andrei <68240139+andrei8l@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: gettingusedto <78019001+gettingusedto@users.noreply.github.com>
Co-authored-by: Francisco Machado <franciscomontenegrolm@gmail.com>
Co-authored-by: Standing-Storm <120433252+Standing-Storm@users.noreply.github.com>
Co-authored-by: ehughsbaird <44244083+ehughsbaird@users.noreply.github.com>
Co-authored-by: Jianxiang Wang (王健翔) <qrox@sina.com>
Co-authored-by: Karol1223 <68503002+Karol1223@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow u_spawn_item to apply flags
2 participants