Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cattail jelly mission turn-in #68077

Merged
merged 1 commit into from
Sep 10, 2023

Conversation

smileynet
Copy link
Contributor

Summary

Bugfixes "Fix Cattail Jelly Mission Turn-in"

Purpose of change

Simple fix to remove "You don't have a cattail stalk!" error, and subsequent error message about the NPC not having the item to consume during mission end for the Cattail Jelly mission.

Describe the solution

Given that this mission often occurs early in the game when the player does not have other large storage objects, (and in the spirit of the mission giving you a duffel bag in the first place) it is likely that they will be carrying the cattail stalks in the duffel bag. The original mission end returned the duffel bag before the cattail stalks generating errors during turn in. This fix reverses the order so that the stalks are turned in first.

Describe alternatives you've considered

Cringe every time I complete this mission, and worry about the new player experience seeing these kind of errors early on.

Testing

Put cattail stalks in duffel bag, turn in mission. Items are turned in correctly with no errors.

Additional context

Signed-off-by: Sam Biggins <sambiggins@gmail.com>
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Missions Quests and missions <Bugfix> This is a fix for a bug (or closes open issue) json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Sep 10, 2023
@Maleclypse Maleclypse merged commit 051b88f into CleverRaven:master Sep 10, 2023
@smileynet smileynet deleted the fix_cattail_mission branch September 10, 2023 22:27
scarf005 added a commit to scarf005/Cataclysm-BN that referenced this pull request Sep 19, 2023
chaosvolt pushed a commit to cataclysmbnteam/Cataclysm-BN that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants