Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Load menu world selection on create/delete #64795

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

sparr
Copy link
Member

@sparr sparr commented Apr 2, 2023

Summary

None

Purpose of change

Creating or deleting a world in the world menu results in the Load menu selecting the wrong world by default for loading

Describe the solution

Move last_world_pos out to the main_menu class, and update it when creating or deleting worlds based on their order

Describe alternatives you've considered

Could pass last_world_pos into world_tab by reference instead of moving it to the class

Testing

Created and deleted worlds and went back and forth between menus

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants