Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the feral burner #57795

Merged
merged 52 commits into from
Nov 28, 2022
Merged

Conversation

MNG-cataclysm
Copy link
Contributor

@MNG-cataclysm MNG-cataclysm commented May 19, 2022

Summary

Content "Add the feral burner"

Purpose of change

Add a new feral military soldier, the feral arsonist, and have it spawn with other feral soldiers.

Describe the solution

Adds a new monster, the feral arsonist. A military-clad zombie which holds a flamethrower and knows how to use it, the arsonist will spawn alongside zombie burners and feral soldiers wherever they occur. It is fairly uncommon, however.

Describe alternatives you've considered

Not adding the arsonist

Testing

Spawning the arsonist works as intended, they operate their weapon properly, and spawn in their monster groups.

Additional context

To prevent the random burning of buildings, the feral burner is required to target players before using their flamethrower.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map astyled astyled PR, label is assigned by github actions labels May 19, 2022
@worm-girl
Copy link
Contributor

worm-girl commented May 19, 2022

Arsonist implies a criminal, not a rogue soldier. Why not call them a feral pyro or feral burner?

Also, there's a reason no existing enemies have flamethrower attacks - fire is way way too deadly right now, and it's stupidly easy to burn buildings down. I don't think we should be putting ambulatory flamethrower monsters into the world until we're at a point where even a single glancing blow from their weapon isn't an instant death sentence. Even a full set of fireproof gear barely helps.

Copy link
Contributor

@worm-girl worm-girl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it/its" should be changed to "they/their" in the flamethrower attack messaging and the feral arsonist description for consistency with other feral enemies as they are human beings, not creatures like zombies.

edit: Github doesn't want to let me actually edit the suggested changes in on my phone. Oh well, you get the idea.

@github-actions github-actions bot added the <Bugfix> This is a fix for a bug (or closes open issue) label Aug 30, 2022
@Night-Pryanik
Copy link
Contributor

If you're actively working on the PR, consider converting it into a draft.

@MNG-cataclysm
Copy link
Contributor Author

If you're actively working on the PR, consider converting it into a draft.

I was just correcting some errors and made a minor description change. Otherwise, I'm not going to alter anything.

@Night-Pryanik
Copy link
Contributor

In that case you need to made it spawn somewhere.

@MNG-cataclysm
Copy link
Contributor Author

MNG-cataclysm commented Aug 30, 2022

In that case you need to made it spawn somewhere.

I’ll go back and fix that.

@MNG-cataclysm
Copy link
Contributor Author

The feral flamer now spawns in mass graves, starting 15 days in.

Copy link
Contributor

@LyleSY LyleSY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with merging this after feature thaw

@MNG-cataclysm
Copy link
Contributor Author

@LyleSY Do you happen to know when the feature thaw will occur?

@LyleSY
Copy link
Contributor

LyleSY commented Aug 31, 2022

The running joke is "SOON". I would guess between two and six months depending on dev availability and interest. I usually switch to Bright Nights content creation during content freeze, which should be pretty soon now

@ZhilkinSerg ZhilkinSerg merged commit 8471a7f into CleverRaven:master Nov 28, 2022
@Ilysen
Copy link
Contributor

Ilysen commented Nov 28, 2022

Didn't erk specifically want to exclude this from stable for a whole bunch of reasons earlier in the convo? Getting flamered right now is a guaranteed death sentence in a lot of circumstances.
image

@I-am-Erk
Copy link
Member

Yeah this probably should be pulled from G-stable and then merged. My bad for not tagging it

@esotericist
Copy link
Contributor

Yeah this probably should be pulled from G-stable and then merged. My bad for not tagging it

point of order, you did tag it, back in july.
image

@sonphantrung
Copy link
Contributor

Uhm, should we "revert" it again, or keep this feral dude around and fixing the facing issues?

@MNG-cataclysm
Copy link
Contributor Author

Uhm, should we "revert" it again, or keep this feral dude around and fixing the facing issues?

How hard would it be to fix the facing issue?

@I-am-Erk
Copy link
Member

We probably should revert this. Stable is days off. We don't need any new chaos

I-am-Erk added a commit that referenced this pull request Nov 30, 2022
@I-am-Erk
Copy link
Member

I-am-Erk commented Nov 30, 2022

Please reopen this PR once it's reverted. It's absolutely something we want and should be merged right after stable is out. Actually, don't, I'll just revert the revert, I have a list for that.

I-am-Erk added a commit that referenced this pull request Nov 30, 2022
@TheMurderUnicorn
Copy link
Contributor

If it has been established that fire is basically just death why would it be readded/desired for the game? It's basically a game over, starting 15 days into the game is too early for insta-death.

Moreover, flamethrowers would not be commonly in use, and while they make sense to appear at mass graves where they would indeed have burned corpses, it relies on those flamethrowers continuing to function/have fuel, and have a feral understand how to start and use the flamethrower. This is not as simple as having a gun and finding that pressing a single button kills whatever you point it at. It also requires them to not be afraid of fire, one of the few universal fears among basically every living thing.

I don't think these make sense from a realism/game lore perspective and I don't think they work for game balance in their current form.

@I-am-Erk
Copy link
Member

I-am-Erk commented Dec 6, 2022

See comments: the solution is then to fix the ongoing issue that fire is basically perma-death, not to avoid ever having fire in game.

Ferals are able to do pretty complex stuff, especially things they know how to do by rote.

@LyleSY
Copy link
Contributor

LyleSY commented Jan 6, 2023

Probably this will not be merged in the future given #62833 Thank you for working on it, I agree it was a reasonable progression given the game state at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.