Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Fixes relic enchantments giving mutations"
Purpose of change
Fixes #42936
Describe the solution
adds a new item::mutations_from_wearing and invokes that in Character::on_wear, while also checking that you don't gain double effects.
Testing
Used this, and a variation of this with different
mutations
to test various mutations, such as gills and rubbery limbsAdditional context
Mutations gained from enchantments still don't cancel current mutations. i don't really want to deal with that in this PR, and it's somewhat amusing to me that you can get weak and strong at the same time in magiclysm. There's also a non-negligible amount of work needed to go into doing that, so that can be punted to a follow-up.