Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mutation enchantment item fix #42950

Merged

Conversation

KorGgenT
Copy link
Member

Summary

SUMMARY: Bugfixes "Fixes relic enchantments giving mutations"

Purpose of change

Fixes #42936

Describe the solution

adds a new item::mutations_from_wearing and invokes that in Character::on_wear, while also checking that you don't gain double effects.

Testing

  {
  "id": "Wildshape Cloak: Fish",
  "type": "ARMOR",
  "name": "Wildshape Cloak: Fish",
  "description": "A magical cloak that shimmers like fresh water under a warm sun. It can be worn to morph your body to a form that is excellent for swimming, but ill-suited for combat.",
  "looks_like": "cloak_leather",
  "weight": "2060 g",
  "volume": "3050 ml",
  "price": 500000,
  "symbol": "w",
  "color": "blue",
  "covers": [ "torso", "arm_l", "arm_r", "leg_l", "leg_r" ],
  "coverage": 0,
  "encumbrance": 0,
  "flags": [ "OUTER", "OVERSIZE", "NONCONDUCTIVE", "WATER_FRIENDLY", "RAINPROOF" ],
    "relic_data": {
    "passive_effects": [
      {
        "has": "WORN",
        "condition": "ALWAYS",
        "mutations": [ "STR_UP" ]
      } 
    ]
  }
  },

Used this, and a variation of this with different mutations to test various mutations, such as gills and rubbery limbs

Additional context

Mutations gained from enchantments still don't cancel current mutations. i don't really want to deal with that in this PR, and it's somewhat amusing to me that you can get weak and strong at the same time in magiclysm. There's also a non-negligible amount of work needed to go into doing that, so that can be punted to a follow-up.

@KorGgenT KorGgenT added Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies <Bugfix> This is a fix for a bug (or closes open issue) Artifacts Otherworldly items with special effects labels Aug 16, 2020
@ZhilkinSerg ZhilkinSerg merged commit cf25f86 into CleverRaven:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Artifacts Otherworldly items with special effects <Bugfix> This is a fix for a bug (or closes open issue) Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some mutations gained by relics not working
2 participants