Fix crash on macOS with clang compiler

[ghost]

Fixes #17714.

[ghost]

Oops, build bot just marked the check failed because Makefile is modified in this PR.

[BevapDin]

The copy assignment operator should be automatically created by the compiler. Does your compiler complain without this?

[ghost]

Here is the whole story: #17714. I suspect clang compiler doesn't copy the std::function object properly with optimization switch turned on, causes the crash.

[SpencerMichaels]

Excellent work, @dlaboratory — Mac users express their gratitude! But I suspect the devs might be overlooking this fix since the Makefile changes make the build fail unconditionally; maybe you could split the bugfix and Makefile alterations into two separate commits?

[ghost]

Okay, changes on Makefile is reverted.

[ghost]

diff --git a/src/npc_class.cpp b/src/npc_class.cpp
index 7a6e467..f369a55 100644
--- a/src/npc_class.cpp
+++ b/src/npc_class.cpp
@@ -383,3 +383,10 @@ distribution distribution::operator*( const distribution &other ) const
         return my_fun() * other_fun();
     } );
 }
+
+distribution &distribution::operator=( const distribution &other )
+{
+    generator_function = other.generator_function;
+    return *this;
+}
+
diff --git a/src/npc_class.h b/src/npc_class.h
index 9e0182f..98c7233 100644
--- a/src/npc_class.h
+++ b/src/npc_class.h
@@ -33,6 +33,7 @@ class distribution

         distribution operator+( const distribution &other ) const;
         distribution operator*( const distribution &other ) const;
+        distribution &operator=( const distribution &other );

         static distribution constant( float val );
         static distribution rng_roll( int from, int to );

[Zireael07]

Why are you closing issues before they can be reviewed/merged?

[cainiaowu]

Yelling at a ghost wont give you any reply, he deleted his account.

[Soyweiser]

Did he delete his/her account or github?