-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable validation for jira issue status #33
Conversation
… Fixed eslint issues
@all-contributors Please review. |
I'll appreciate if the maintainers can review this PR please |
Hey @NasAmin! Thanks for your contribution & raising this PR! Really glad you found this action useful :) We've had issues with the markdown/markup syntax not getting reproduced correctly in the GitHub PR description. Could you add some screenshots of this in a test repo with the working PR description? Unfortunately we only have this means of manual testing.. I don't have write access to this repo anymore, although @loftykhanna could help out here! @loftykhanna: Could you have a 👀 on this PR, please? |
@rheaditi Thanks for getting back to me. If you are talking about the general PR description bit of jira-lint then I can look into that but it should probably be a separate PR. |
@loftykhanna @maddhruv I would really appreciate if you can review and approve this PR and release it. @rheaditi regarding the PR description issue, I am using the release version of this action and it is producing the PR descriptions just fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NasAmin have a few minor comments.. Please take a look whenever you get time 🙂
Co-authored-by: Aditi Mohanty <rheaditi@users.noreply.github.com>
Co-authored-by: Aditi Mohanty <rheaditi@users.noreply.github.com>
Co-authored-by: Aditi Mohanty <rheaditi@users.noreply.github.com>
Co-authored-by: Aditi Mohanty <rheaditi@users.noreply.github.com>
Co-authored-by: Aditi Mohanty <rheaditi@users.noreply.github.com>
@loftykhanna Thanks for testing this. Not sure how I can easily test the PR comment bit if it fails but it might have been because the Regarding |
@rheaditi and @loftykhanna thank you both for reviewing my code. I have addressed all the comments (I think). If there is a way to write some kind of automated test then that would be great for the future. |
@NasAmin Sure let me test and get back to you on this. |
@NasAmin Thank you for your contribution, Its working fine now 👍 |
Enables validation of jira issue status against a list of allowed statuses provided as an action input.
This implements #32
Please refer to #32 for more details.