Implement updated ForeachBaggageItem from OpenTracing

Clarilab · Jun 30, 2016 · ff8409d · ff8409d
1 parent 9e26371
commit ff8409d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/glide.lock b/glide.lock
diff --git a/glide.yaml b/glide.yaml
@@ -5,7 +5,7 @@ import:
   subpackages:
   - lib/go/thrift
 - package: github.com/opentracing/opentracing-go
-  version: 01498abd158dfdbe8e251856bc7d14cb0f046fa3
+  version: d5b9be1fcf7d467664d3b8f9cb4f3c8c5ac0a753
   subpackages:
   - ext
 - package: golang.org/x/net

diff --git a/span.go b/span.go
@@ -172,11 +172,13 @@ func (s *span) BaggageItem(key string) string {
 	return s.baggage[key]
 }
 
-func (s *span) ForeachBaggageItem(handler func(k, v string)) {
+func (s *span) ForeachBaggageItem(handler func(k, v string) bool) {
 	s.RLock()
 	defer s.RUnlock()
 	for k, v := range s.baggage {
-		handler(k, v)
+		if !handler(k, v) {
+			break
+		}
 	}
 }
 

diff --git a/span_test.go b/span_test.go
@@ -14,8 +14,16 @@ func TestBaggageIterator(t *testing.T) {
 	sp1.SetBaggageItem("Some-other-key", "42")
 
 	b := make(map[string]string)
-	sp1.ForeachBaggageItem(func(k, v string) {
+	sp1.ForeachBaggageItem(func(k, v string) bool {
 		b[k] = v
+		return true
 	})
 	assert.Equal(t, map[string]string{"some-key": "12345", "some-other-key": "42"}, b)
+
+	b = make(map[string]string)
+	sp1.ForeachBaggageItem(func(k, v string) bool {
+		b[k] = v
+		return false // break out early
+	})
+	assert.Equal(t, 1, len(b), "only one baggage item should be extracted")
 }