Implement ForeachBaggageItem (jaegertracing#15)

span.go

@@ -172,6 +172,14 @@ func (s *span) BaggageItem(key string) string {
 	return s.baggage[key]
 }
 
+func (s *span) ForeachBaggageItem(handler func(k, v string)) {
+	s.RLock()
+	defer s.RUnlock()
+	for k, v := range s.baggage {
+		handler(k, v)
+	}
+}
+
 func (s *span) Tracer() opentracing.Tracer {
 	return s.tracer
 }

span_test.go

@@ -0,0 +1,21 @@
+package jaeger
+
+import (
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestBaggageIterator(t *testing.T) {
+	tracer, closer := NewTracer("DOOP", NewConstSampler(true), NewNullReporter())
+	defer closer.Close()
+
+	sp1 := tracer.StartSpan("s1").(*span)
+	sp1.SetBaggageItem("Some_Key", "12345")
+	sp1.SetBaggageItem("Some-other-key", "42")
+
+	b := make(map[string]string)
+	sp1.ForeachBaggageItem(func(k, v string) {
+		b[k] = v
+	})
+	assert.Equal(t, map[string]string{"some-key": "12345", "some-other-key": "42"}, b)
+}

tracer_test.go

@@ -78,7 +78,7 @@ func (s *tracerSuite) TestBeginRootSpan() {
 	ss := sp.(*span)
 	s.NotNil(ss.tracer, "Tracer must be referenced from span")
 	s.Equal("get_name", ss.operationName)
-	s.Equal("s", ss.spanKind, "Span must be server-side")
+	s.Equal("server", ss.spanKind, "Span must be server-side")
 	s.Equal("peer-service", ss.peer.ServiceName, "Client is 'peer-service'")
 
 	s.EqualValues(someID, ss.traceID)