Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Docker fixes & features #68

Merged
merged 3 commits into from
Oct 29, 2023
Merged

Small Docker fixes & features #68

merged 3 commits into from
Oct 29, 2023

Conversation

joleaf
Copy link
Contributor

@joleaf joleaf commented Oct 29, 2023

Hi,
small improvements for the Dockerfile:

  • Fix a permission error in the Dockerfile (the app container had no permission to create a folder/file in the upload folder and failed )
  • Add healthcheck in the docker-compose.yml file to prevent the container app from failing, if the postgres container is not ready
  • Add a docker-compose-dev.yml file (and the description to use it) to easily create a local test environment
  • Renamed docker-compose ... -> docker compose ..(see https://docs.docker.com/compose/migrate/)

@alxlion
Copy link
Contributor

alxlion commented Oct 29, 2023

Nice to have 👍 thanks !

@alxlion alxlion merged commit 697b546 into ClaperCo:dev Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants