Bounty issue #42 solved: Pin messages sent by attendees

[haruncurak]

/claim #42

[alxlion]

I changed the branch to be in sync with the official dev branch. I let you resolve conflicts and fix credo errors (mix credo). For the yarn.lock you can delete it and for package-lock.json, take the last version in the dev branch.

[haruncurak]

Should all be complete - let me know if you need any other changes!

[alxlion]

Nice work @haruncurak, there is just a problem with the message ordering. On the presenter and manager, new messages come at the top, but it should be at the bottom (like on the attendee view).

I think it's because of the “show pinned on top” feature that was a little tricky. Maybe if we simplify this part with a new tab called "Pinned messages" showing only the pinned messages. What do you think?

[haruncurak]

Hey @alxlion I can do that as well. Should I extend the new messages at the bottom to the pinned messages as well? The issue might be when unpinning messages - do we want them to go back to where they were or to the bottom?

[alxlion]

Should I extend the new messages at the bottom to the pinned messages as well?

This tab will contain only the pinned messages but yes, always the oldest messages at the top and the newest at the bottom.

do we want them to go back to where they were or to the bottom

When you unpin from Message tab, it will only update the count of pinned messages. When you unpin from Pinned Message tab, it will remove the message from the list.

[haruncurak]

Hi @alxlion, got a bit caught up with other work - I'll work on this soon

[alxlion]

No problem, no pressure. Thanks for your work 😉

[alxlion]

@haruncurak Are you still ok for to work on this?

[haruncurak]

Yep! If it's ok with you i was gonna finish the edits by mid-week next week. Just got caught up with other job-related stuff

[haruncurak]

Hey @alxlion! Worked on this today and I think I was able to finish it. Feel free to test it out and see if it's the expected behavior. Sorry for the delays once again.

[haruncurak]

If you'd like I can modify the show view to display messages from oldest to newest top-down as well - I think this was the case independently of my work but not too sure

[alxlion]

@haruncurak Well played! Your PR has been merged 😉

I will do the minor fixes like message order myself.