Fix forms UX

ClaperCo · Oct 19, 2024 · 6f8a2fd · 6f8a2fd
1 parent d6c48a3
commit 6f8a2fd
Show file tree

Hide file tree

Showing 9 changed files with 81 additions and 4 deletions.
diff --git a/lib/claper_web/live/event_live/event_form_component.ex b/lib/claper_web/live/event_live/event_form_component.ex
@@ -86,12 +86,19 @@ defmodule ClaperWeb.EventLive.EventFormComponent do
       end)
 
     changeset =
+      socket.assigns.changeset
+      |> Ecto.Changeset.put_assoc(:leaders, leaders)
+
+    # Preserve other event fields and changes
+    updated_changeset =
       case leaders do
-        [] -> Events.change_event(socket.assigns.event, %{leaders: leaders})
-        _ -> socket.assigns.changeset |> Ecto.Changeset.put_assoc(:leaders, leaders)
+        [] ->
+          Events.change_event(socket.assigns.event, Map.put(socket.assigns.changeset.changes, :leaders, []))
+        _ ->
+          changeset
       end
 
-    {:noreply, assign(socket, changeset: changeset)}
+    {:noreply, assign(socket, changeset: updated_changeset)}
   end
 
   defp get_temp_id, do: :crypto.strong_rand_bytes(5) |> Base.url_encode64() |> binary_part(0, 5)

diff --git a/lib/claper_web/live/event_live/manage.ex b/lib/claper_web/live/event_live/manage.ex
@@ -684,7 +684,7 @@ defmodule ClaperWeb.EventLive.Manage do
     socket
     |> assign(:create, "poll")
     |> assign(:poll, %Polls.Poll{
-      poll_opts: [%Polls.PollOpt{id: 0}, %Polls.PollOpt{id: 1}]
+      poll_opts: [%Polls.PollOpt{content: gettext("Yes")}, %Polls.PollOpt{content: gettext("No")}]
     })
   end
 

diff --git a/priv/gettext/de/LC_MESSAGES/default.po b/priv/gettext/de/LC_MESSAGES/default.po
@@ -1602,3 +1602,13 @@ msgstr "Beenden"
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr "Weitere Optionen"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr "Nein"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr "Ja"
diff --git a/priv/gettext/default.pot b/priv/gettext/default.pot
@@ -1604,3 +1604,13 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr ""
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr ""
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr ""
diff --git a/priv/gettext/en/LC_MESSAGES/default.po b/priv/gettext/en/LC_MESSAGES/default.po
@@ -1602,3 +1602,13 @@ msgstr ""
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr ""
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr ""
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr ""
diff --git a/priv/gettext/es/LC_MESSAGES/default.po b/priv/gettext/es/LC_MESSAGES/default.po
@@ -1602,3 +1602,13 @@ msgstr "Finalizar"
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr "Más opciones"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr "No"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr "Sí"
diff --git a/priv/gettext/fr/LC_MESSAGES/default.po b/priv/gettext/fr/LC_MESSAGES/default.po
@@ -1607,3 +1607,13 @@ msgstr "Terminer"
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr "Plus d'options"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr "Non"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr "Oui"
diff --git a/priv/gettext/it/LC_MESSAGES/default.po b/priv/gettext/it/LC_MESSAGES/default.po
@@ -1603,3 +1603,13 @@ msgstr "Fine"
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr "Altre opzioni"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr "No"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr "Sì"
diff --git a/priv/gettext/nl/LC_MESSAGES/default.po b/priv/gettext/nl/LC_MESSAGES/default.po
@@ -1602,3 +1602,13 @@ msgstr "Beëindigen"
 #, elixir-autogen, elixir-format
 msgid "More options"
 msgstr "Meer opties"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "No"
+msgstr "Nee"
+
+#: lib/claper_web/live/event_live/manage.ex:687
+#, elixir-autogen, elixir-format
+msgid "Yes"
+msgstr "Ja"