Kconfig: Build-time warning and minimum version requirement for Clang #941

dileks · 2020-03-21T13:59:39Z

Just saw these commits in peterz/queue.git#locking/atomics [1]:

"compiler/gcc: Emit build-time warning for GCC prior to version 4.8"
"compiler/gcc: Raise minimum GCC version for kernel builds to 4.8"

...and what do people think to do this analog for Clang (CC_IS_CLANG) to what there is for CC_IS_GCC and GCC_VERSION and move/improve the checks to/in scripts/Kconfig.include and add the minimum requirement of CLANG_VERSION?

We had a discussion/brainstorming about that on the ClangBuiltLinux meetup in Zurich.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/log/?h=locking/atomics
[2] https://lkml.kernel.org/r/20200123153341.19947-2-will@kernel.org
[3] https://lkml.kernel.org/r/20200123153341.19947-10-will@kernel.org

The text was updated successfully, but these errors were encountered:

dileks · 2020-03-21T14:15:31Z

Analog for include/linux/compiler-clang.h:

[ include/linux/compiler-gcc.h ]

/*
 * Common definitions for all gcc versions go here.
 */
#define GCC_VERSION (__GNUC__ * 10000		\
		     + __GNUC_MINOR__ * 100	\
		     + __GNUC_PATCHLEVEL__)

/* https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58145 */
#if GCC_VERSION < 40800
# error Sorry, your compiler is too old - please upgrade it.
#endif

https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git/tree/include/linux/compiler-gcc.h?h=locking/atomics

dileks · 2020-03-21T14:32:11Z

[ Suggestion for the build-time warning part ]

According to scripts/clang-version.sh:

MAJOR=$(echo __clang_major__ | $compiler -E -x c - | tail -n 1)
MINOR=$(echo __clang_minor__ | $compiler -E -x c - | tail -n 1)
PATCHLEVEL=$(echo __clang_patchlevel__ | $compiler -E -x c - | tail -n 1)

...this should result in something like this for the minimum requirement of version 9.0.0:

[ include/linux/compiler-clang.h ]

/*
 * Common definitions for all clang versions go here.
 */
#define CLANG_VERSION (__clang_major__ * 10000 \
		       + __clang_minor__ * 100 \
		       + __clang_patchlevel__)

#if CLANG_VERSION < 90000
# error Sorry, your compiler is too old - please upgrade it.
#endif

NOTE-1: Better warn than error? Is there a consensus on version 9 as minimum?
NOTE-2: Implement as arch-specific warnings/errors?
NOTE-3: What about LLVM utilities such as LLD and its minimum version requirement?

[ Documentation/process/changes.rst ]

 ====================== ===============  ========================================
         Program        Minimal version       Command to check the version
 ====================== ===============  ========================================
 
Clang                  9.0              clang --version

dileks · 2020-03-21T14:50:45Z

[ Suggestion for further Kconfig improvements for CC_IS_XXX and CC_VERSION handling ]

Sample code snippet on top what is in peterz/queue.git#locking/atomic (for demonstration reasons I have included the GCC changes):

[ init/Kconfig ]

 config CC_IS_GCC
-	def_bool $(success,$(CC) --version | head -n 1 | grep -q gcc)
+	def_bool $(cc-is-gcc)
 
 config GCC_VERSION
 	int
-	default $(shell,$(srctree)/scripts/gcc-version.sh $(CC)) if CC_IS_GCC
+	default $(gcc-version) if CC_IS_GCC

config CC_IS_CLANG
-	default $(shell,$(srctree)/scripts/clang-version.sh $(CC))
+	def_bool $(cc-is-clang)

config CLANG_VERSION
	int
-       def_bool $(success,$(CC) --version | head -n 1 | grep -q clang)
+       default $(clang-version) if CC_IS_CLANG


[ scripts/Kconfig.include ]

# gcc version including patch level
gcc-version := $(shell,$(srctree)/scripts/gcc-version.sh $(CC))

+# Return y if the compiler is GCC, n otherwise
+cc-is-gcc := $(success,$(CC) --version | head -n 1 | grep -q gcc)

+# clang version including patch level
+clang-version := $(shell,$(srctree)/scripts/clang-version.sh $(CC))

+# Return y if the compiler is Clang, n otherwise
+cc-is-clang := $(success,$(CC) --version | head -n 1 | grep -q clang)

NOTE: Might be better `cc-is-xxx` before `cc-version` analog to `init/Kconfig` (see above).

dileks · 2020-03-21T16:25:26Z

Another options is to document such informations in Documentation/kbuild/llvm.rst (see commit
Documentation/llvm: add documentation on building w/ Clang/LLVM pending in linux-kbuild.git#for-next).

[1] https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git/commit/?h=for-next&id=fcf1b6a35c16ac500fa908a4022238e5d666eabf

nathanchance · 2020-03-22T02:44:37Z

I'll comment here for now rather than on the email thread that you started. I think that the technical implementation of this is completely benign and should not be the focus of discussion. I think we need to discuss the meta/logistics of this level of change. Some of my initial thoughts to spur further discussion...

Somewhat objective brain dump

By setting a minimum supported version, we have to be committed to keep it building with that version. Look at all of the code that is being ripped out. We would have to be willing to insert similar hacks or workarounds to keep whatever minimum version we choose working properly or we have to be okay with constantly bumping the minimum version whenever we fix a severe enough bug.

Historically, the kernel community's attitude towards GCC bugs is report them and pray they eventually get fixed while inserting a hack working around it (or raising the minimum version like in this case). It seems like the kernel community's attitude towards clang bugs has been "fix your compiler"; in this scheme, it becomes more complicated. The core kernel community would have to take clang seriously for this to work properly.

Completely opinionated brain dump

I was initially pro-minimum clang version but as I have thought more about it, I do not believe we are ready for this change. We are still working on adding architectures. We are still working on the integrated assembler. We are still working on getting warnings down to zero, which may still require further clang changes. We do not have a ton of contributors to help with issues, which would undoubtedly grow if we are stamping our seal that we are "ready" to be in Documentation/process/changes.rst.

Furthermore, if we are being completely realistic, we do not really have great testing in place for making sure that all of this stuff stays working. Our CI is limited by Travis's build capacity. KernelCI is using clang-9, which is great, but they are not entirely within our control and they are not testing everything for us. 0day is using tip of tree (which is great so we can avoid breakage up there) but they give us no coverage of older clang versions. Something that I want to do with my next two weeks off (yay, coronavirus...) is create a testing framework to qualify a release version of clang, which would build a version of clang from source, build every known working config, and boot it if need be, which we could use every time that Hans/Tom release a new LLVM release candidate. By extension, we could use that framework to find a suitable minimum version.

If we want to give some sort of indication of what clang version should work for the kernel, I would say we should add it to Documentation/kbuild/llvm.rst (which might actually be a better place for this kind of information anyways?) and keep it soft: "LLVM 9 and higher is known to work better due to the implementation of such features such as asm goto".

dileks · 2020-03-22T06:40:23Z

Thanks @nathanchance for your thoughts.

As said Documentation/kbuild/llvm.rs is currently the best place to document the current situation.

Anyway, I want to get some feedback here on other architectures than x86-64 what I am using.

Also, some feedback on the LLVM utilities like LLD & Co is welcome.

Clang/LLVM version 10 will be released hopefully next week which will be more "suitable" to build current versions of the Linux-kernel.

dileks · 2020-03-27T15:16:09Z

Something like these patch (tested against Linux v5.6-rc7).

Tried to build with clang-9 as compiler which errors.

kconfig-Rework-compiler-identification-and-version-handling.txt
compiler-clang-Emit-build-time-warning-for-Clang-prior-to-version-10-0.txt

dileks · 2020-03-30T18:47:40Z

Re-tested both patches with clang-10 and Linux v5.6 by lowering version check to v9.0.0 as minimum.

dileks · 2020-04-10T06:50:43Z

Added patches on top of kbuild-next (RFC status!).

[PATCH] kconfig: Rework compiler identification and version handling (v2)
[PATCH] compiler/clang: Emit build-time warning for Clang prior to version 9.0.0

Note: I use this patchset with my experiments starting with Linux v5.6-rc7.

0001-kconfig-Rework-compiler-identification-and-version-h_patch.txt
0002-compiler-clang-Emit-build-time-warning-for-Clang-pri_patch.txt

nathanchance · 2020-04-10T07:32:11Z

I still do not really like the idea of doing this yet but if there is a general consensus then I will not argue.

What's the point of the first patch? We can use CONFIG_CC_IS_CLANG and CONFIG_CLANG_VERSION in C, Kconfig, and make files, why do we need cc-is-clang, clang-version, etc?

The second patch's title needs to be improved I think. We aren't warning about an older clang, we're straight up breaking the build.

I've started working on the testing framework that I mentioned in the post, you can see it here. Once LLVM 10.0.1-rc1 gets posted, I'll be able to see how it truly works as I have definitely tripped over quite a few bugs in LLVM 10.0.0. Until that happens though, I do not feel comfortable limiting ourselves with a patch like this. We have to ensure that LLVM releases do not regress before we can start saying "hey, this version will DEFINITELY work".

dileks · 2020-07-10T20:02:33Z

New discussion in thread "[PATCH] Restore gcc check in mips asm/unroll.h"

[1] https://lore.kernel.org/r/20200709221102.323356-1-cesarb@cesarb.eti.br/

dileks · 2020-08-26T15:55:55Z

From @nickdesaulniers

"Documentation: add minimum clang/llvm version"

[1] https://lore.kernel.org/r/20200825222552.3113760-1-ndesaulniers@google.com/

nickdesaulniers · 2020-08-26T20:18:06Z

https://lore.kernel.org/lkml/20200826201420.3414123-1-ndesaulniers@google.com/T/#u

During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. Older clang's may work, but we will likely drop workarounds for older versions. Link: ClangBuiltLinux#9 Link: ClangBuiltLinux#941 Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

nickdesaulniers · 2020-08-31T23:48:23Z

Jon Corbet picked up the Documentation patch: https://lore.kernel.org/lkml/20200831163048.0cbeca5d@lwn.net/

I need to resend the header.

nickdesaulniers · 2020-09-01T00:26:54Z

v2: https://lore.kernel.org/lkml/20200901002326.1137289-1-ndesaulniers@google.com/T/#t

nickdesaulniers · 2020-09-02T22:59:58Z

v3: https://lore.kernel.org/lkml/20200902225911.209899-1-ndesaulniers@google.com/T/#t

During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Link: ClangBuiltLinux#9 Link: ClangBuiltLinux#941

Patch series "set clang minimum version to 10.0.1", v3. Adds a compile time #error to compiler-clang.h setting the effective minimum supported version to clang 10.0.1. A separate patch has already been picked up into the Documentation/ tree also confirming the version. Next are a series of reverts. One for 32b arm is a partial revert. Then Marco suggested fixes to KASAN docs. Finally, improve the warning for GCC too as per Kees. This patch (of 7): During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Link: https://lkml.kernel.org/r/20200902225911.209899-1-ndesaulniers@google.com Link: https://lkml.kernel.org/r/20200902225911.209899-2-ndesaulniers@google.com Link: ClangBuiltLinux#9 Link: ClangBuiltLinux#941 Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andrey Konovalov <andreyknvl@google.com> Cc: Fangrui Song <maskray@google.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>

Patch series "set clang minimum version to 10.0.1", v3. Adds a compile time #error to compiler-clang.h setting the effective minimum supported version to clang 10.0.1. A separate patch has already been picked up into the Documentation/ tree also confirming the version. Next are a series of reverts. One for 32b arm is a partial revert. Then Marco suggested fixes to KASAN docs. Finally, improve the warning for GCC too as per Kees. This patch (of 7): During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andrey Konovalov <andreyknvl@google.com> Cc: Fangrui Song <maskray@google.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Link: https://lkml.kernel.org/r/20200902225911.209899-1-ndesaulniers@google.com Link: https://lkml.kernel.org/r/20200902225911.209899-2-ndesaulniers@google.com Link: ClangBuiltLinux#9 Link: ClangBuiltLinux#941 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

nathanchance · 2020-10-15T05:32:01Z

We have committed to LLVM 10.0.1 for the time being and that series of patches has landed in 5.10 now. Closing this for now.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/?h=c8db3b0a7ba7614f761f309d6aa7499127b18a0b
https://git.kernel.org/linus/3519c4d6e08ea695658b961829d4a603acf8e28a

Patch series "set clang minimum version to 10.0.1", v3. Adds a compile time #error to compiler-clang.h setting the effective minimum supported version to clang 10.0.1. A separate patch has already been picked up into the Documentation/ tree also confirming the version. Next are a series of reverts. One for 32b arm is a partial revert. Then Marco suggested fixes to KASAN docs. Finally, improve the warning for GCC too as per Kees. This patch (of 7): During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andrey Konovalov <andreyknvl@google.com> Cc: Fangrui Song <maskray@google.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Link: https://lkml.kernel.org/r/20200902225911.209899-1-ndesaulniers@google.com Link: https://lkml.kernel.org/r/20200902225911.209899-2-ndesaulniers@google.com Link: ClangBuiltLinux/linux#9 Link: ClangBuiltLinux/linux#941 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Patch series "set clang minimum version to 10.0.1", v3. Adds a compile time #error to compiler-clang.h setting the effective minimum supported version to clang 10.0.1. A separate patch has already been picked up into the Documentation/ tree also confirming the version. Next are a series of reverts. One for 32b arm is a partial revert. Then Marco suggested fixes to KASAN docs. Finally, improve the warning for GCC too as per Kees. This patch (of 7): During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andrey Konovalov <andreyknvl@google.com> Cc: Fangrui Song <maskray@google.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Link: https://lkml.kernel.org/r/20200902225911.209899-1-ndesaulniers@google.com Link: https://lkml.kernel.org/r/20200902225911.209899-2-ndesaulniers@google.com Link: ClangBuiltLinux/linux#9 Link: ClangBuiltLinux/linux#941 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: EndCredits <endcredits@crepuscular-aosp.icu>

Patch series "set clang minimum version to 10.0.1", v3. Adds a compile time #error to compiler-clang.h setting the effective minimum supported version to clang 10.0.1. A separate patch has already been picked up into the Documentation/ tree also confirming the version. Next are a series of reverts. One for 32b arm is a partial revert. Then Marco suggested fixes to KASAN docs. Finally, improve the warning for GCC too as per Kees. This patch (of 7): During Plumbers 2020, we voted to just support the latest release of Clang for now. Add a compile time check for this. We plan to remove workarounds for older versions now, which will break in subtle and not so subtle ways. Suggested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Nathan Chancellor <natechancellor@gmail.com> Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> Reviewed-by: Sedat Dilek <sedat.dilek@gmail.com> Acked-by: Marco Elver <elver@google.com> Acked-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Sedat Dilek <sedat.dilek@gmail.com> Cc: Andrey Konovalov <andreyknvl@google.com> Cc: Fangrui Song <maskray@google.com> Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Daniel Borkmann <daniel@iogearbox.net> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Will Deacon <will@kernel.org> Cc: Vincenzo Frascino <vincenzo.frascino@arm.com> Link: https://lkml.kernel.org/r/20200902225911.209899-1-ndesaulniers@google.com Link: https://lkml.kernel.org/r/20200902225911.209899-2-ndesaulniers@google.com Link: ClangBuiltLinux/linux#9 Link: ClangBuiltLinux/linux#941 Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

dileks added the enhancement New feature or request label Mar 21, 2020

nathanchance added the question Question asked by issue author. label Mar 22, 2020

nickdesaulniers mentioned this issue Apr 2, 2020

%ecx' not allowed with orb' #961

Closed

nickdesaulniers self-assigned this Aug 26, 2020

nickdesaulniers added [PATCH] Submitted A patch has been submitted for review and removed question Question asked by issue author. labels Aug 26, 2020

nathanchance closed this as completed Oct 15, 2020

nathanchance added [FIXED][LINUX] 5.10 This bug was fixed in Linux 5.10 and removed [PATCH] Submitted A patch has been submitted for review labels Oct 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kconfig: Build-time warning and minimum version requirement for Clang #941

Kconfig: Build-time warning and minimum version requirement for Clang #941

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

nathanchance commented Mar 22, 2020

dileks commented Mar 22, 2020 •

edited

Loading

dileks commented Mar 27, 2020 •

edited

Loading

dileks commented Mar 30, 2020

dileks commented Apr 10, 2020 •

edited

Loading

nathanchance commented Apr 10, 2020

dileks commented Jul 10, 2020 •

edited by nathanchance

Loading

dileks commented Aug 26, 2020 •

edited by nathanchance

Loading

nickdesaulniers commented Aug 26, 2020

nickdesaulniers commented Aug 31, 2020

nickdesaulniers commented Sep 1, 2020

nickdesaulniers commented Sep 2, 2020

nathanchance commented Oct 15, 2020

Kconfig: Build-time warning and minimum version requirement for Clang #941

Kconfig: Build-time warning and minimum version requirement for Clang #941

Comments

dileks commented Mar 21, 2020 • edited Loading

dileks commented Mar 21, 2020 • edited Loading

dileks commented Mar 21, 2020 • edited Loading

dileks commented Mar 21, 2020 • edited Loading

dileks commented Mar 21, 2020 • edited Loading

nathanchance commented Mar 22, 2020

Somewhat objective brain dump

Completely opinionated brain dump

dileks commented Mar 22, 2020 • edited Loading

dileks commented Mar 27, 2020 • edited Loading

dileks commented Mar 30, 2020

dileks commented Apr 10, 2020 • edited Loading

nathanchance commented Apr 10, 2020

dileks commented Jul 10, 2020 • edited by nathanchance Loading

dileks commented Aug 26, 2020 • edited by nathanchance Loading

nickdesaulniers commented Aug 26, 2020

nickdesaulniers commented Aug 31, 2020

nickdesaulniers commented Sep 1, 2020

nickdesaulniers commented Sep 2, 2020

nathanchance commented Oct 15, 2020

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 21, 2020 •

edited

Loading

dileks commented Mar 22, 2020 •

edited

Loading

dileks commented Mar 27, 2020 •

edited

Loading

dileks commented Apr 10, 2020 •

edited

Loading

dileks commented Jul 10, 2020 •

edited by nathanchance

Loading

dileks commented Aug 26, 2020 •

edited by nathanchance

Loading