Skip to content

Commit

Permalink
hwmon: (adt7470) Prevent divide by zero in adt7470_fan_write()
Browse files Browse the repository at this point in the history
The "val" variable is controlled by the user and comes from
hwmon_attr_store().  The FAN_RPM_TO_PERIOD() macro divides by "val"
so a zero will crash the system.  Check for that and return -EINVAL.
Negatives are also invalid so return -EINVAL for those too.

Fixes: fc958a6 ("hwmon: (adt7470) Convert to devm_hwmon_device_register_with_info API")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
  • Loading branch information
Dan Carpenter authored and groeck committed Jan 24, 2022
1 parent f1e75e0 commit c1ec0ca
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/hwmon/adt7470.c
Original file line number Diff line number Diff line change
Expand Up @@ -662,6 +662,9 @@ static int adt7470_fan_write(struct device *dev, u32 attr, int channel, long val
struct adt7470_data *data = dev_get_drvdata(dev);
int err;

if (val <= 0)
return -EINVAL;

val = FAN_RPM_TO_PERIOD(val);
val = clamp_val(val, 1, 65534);

Expand Down

0 comments on commit c1ec0ca

Please sign in to comment.