Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS alignment of social share buttons #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adsingh14
Copy link

Solved Issue: #3

Description:

  • Social button's won't overlap on desktop view.

image

  • Social Icons fixed on scrolling blog content on desktop view.

@netlify
Copy link

netlify bot commented Oct 11, 2021

👷 Deploy request for chetanblog accepted.

🔨 Explore the source changes: c2935f2

🔍 Inspect the deploy log: https://app.netlify.com/sites/chetanblog/deploys/616496a7f17c8300085b0a28

@Ckbhatia
Copy link
Owner

Ckbhatia commented Oct 11, 2021

You are almost there.

It should be visible with the article cover image and fixed there and should be moved when the article ends not before.

@Ckbhatia
Copy link
Owner

Ckbhatia commented Oct 11, 2021

Scroll End:
Scroll end

@adsingh14
Copy link
Author

Scroll End: Scroll end

Do you want to place it in bottom fixed position or bottom sticky position ?

@Ckbhatia
Copy link
Owner

Share initial: ( no scroll )
share-initial

Share scroll:
Screenshot 2021-10-11 at 9 56 41 PM

@Ckbhatia
Copy link
Owner

@adsingh14
Copy link
Author

@Ckbhatia PR updated.

@Ckbhatia
Copy link
Owner

Thanks

@Ckbhatia Ckbhatia added the In review This PR is in review label Oct 13, 2021
@Ckbhatia
Copy link
Owner

@adsingh14 It's working for some fixed length articles only not on others. Please try to put dynamic values to positioning properties.

@adsingh14
Copy link
Author

Well, I've tested using Devtools. May I know what particular device doesn't showing it as expected?

@Ckbhatia
Copy link
Owner

Ckbhatia commented Oct 13, 2021

No, it's not about any device. It has a fixed top position where it requires dynamic value as per article text, cover image and title heading.

@adsingh14
Copy link
Author

adsingh14 commented Oct 13, 2021

Well, I have a single blog under 'Demo' credentials. Can you add a few so I create similar cases on local ?

@Ckbhatia
Copy link
Owner

Ckbhatia commented Oct 13, 2021 via email

@adsingh14

This comment has been minimized.

@Ckbhatia
Copy link
Owner

Space ID: 0dxfiyfxoovv

Content Delivery API - the access token

aQ8VH0ajavUGJur3I6LGRTZvjYf25s9ILko6bgLU9z8

Content Preview API - access token

Vn3YH_guhFjM5NXkD8wfdI0YZy0os4IigbAX5mT-Go0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In review This PR is in review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants