New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated recaptcha implementation #566

Merged

johnyu95 merged 2 commits into main from johnyu95-recaptcha

Sep 20, 2023

Contributor

johnyu95 commented Sep 18, 2023

This PR rewrites the OpenRecords recaptcha implementation.

Notes:

Previous implementation was not working properly because responses where not verified using https://www.google.com/recaptcha/api/siteverify.
Removed recaptcha_utils.py and references using Recaptcha3Field.
Referenced implementation in Women's Activism Recaptcha nycrecords/womens_activism_nyc#26.
For local development you can disable recaptcha by setting RECAPTCHA_ENABLED=False in .env.


          Updated recaptcha implementation

c070b49

johnyu95 requested a review from zgary

September 18, 2023 15:27

johnyu95 assigned zgary


          Added try/except to recaptcha response verification

05828c1

zgary approved these changes

View reviewed changes

Contributor

zgary left a comment

Looks good 👍

johnyu95 merged commit 6256f55 into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet