OpenRecords v3.1.0 #490
Merged
OpenRecords v3.1.0 #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Codacy fixes for camelCase vars in javascript Update to requirements CSV only inclues requests belonging to that user's agency Fixed spinner bug with responses and histroy Fixed responses loading bug: Changed block ui colors
* develop: Added eval bool check to reasons populate function Cleanup email_closing_handler Adds has_appeals_language to reasons.csv Adds check for appeals language for reasons in closing and denial Added has_appeals_langauge to reasons table
…min functionality
Feature/OP-1470: Updated FAQ language for date calculations
Feature/OP-1587: Generate Acknowledgment Report
* develop: Added tablib to requirements PR changes Updated FAQ langauge for date calculations Update with codacy fixes and turn on celery Working implementation of form with reduced database load Rewrite query to reduce DB load Add all opened requests data in report Removed new line Turned user agencies into a hidden select instead of input Added N/A for requests that have no date closed Add messaging about redacted requests in search results Backend validation WIP Working generate_acknowledgment_report celery task with email Working acknowlegment report csv on form submission Acknowledgment report functionality WIP Frontend for Agency Reports WIP FOIL acknowledgment status report WIP
Feature/OP-1527: FDNY Custom Forms
Fix Session Timeout Dialog
Hotfix/v3.0.1 Co-authored-by: Gary Zhou <garyzhouny@gmail.com>
| @@ -8,7 +8,7 @@ | |||
| <p>{{ help_text }}</p> | |||
| {% endif %} | |||
| {% for option in options %} | |||
| <input class="custom-request-form-data" type="radio" id="{{ field_name }}-{{ instance_id }}" name="{{ field_name }}-{{ instance_id }}" value="{{ option }}" style="display: inline;"/> {{ option }}<br> | |||
| <input class="custom-request-form-data" type="radio" id="{{ field_name }}-{{ instance_id }}" name="{{ field_name }}-{{ instance_id }}" value="{{ option }}" style="display: inline;" {% if field_required %}data-parsley-required{% endif %}/> {{ option }}<br> | |||
There was a problem hiding this comment.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.
zgary
approved these changes
Mar 21, 2019
|
This pull request fixes 6 alerts when merging 370fb1f into 5e26b4d - view on LGTM.com fixed alerts:
Comment posted by LGTM.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.