Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump requests to latest #870

Merged
merged 1 commit into from
May 24, 2023
Merged

Bump requests to latest #870

merged 1 commit into from
May 24, 2023

Conversation

nicobav
Copy link
Contributor

@nicobav nicobav commented May 24, 2023

Security issues with old versions

Security issues with old versions
@nicobav nicobav requested a review from saaste May 24, 2023 09:22
Copy link
Contributor

@saaste saaste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grreeeeeat! Just comment about not using the deprecated resolver. Feel free to check it out if it makes any difference.

# by the following command:
#
# pip-compile --resolver=backtracking requirements_dev.in
# pip-compile requirements_dev.in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it makes any difference in the generated file, but should we generate these with --resolver=backtracking just to avoid using the deprecated resolver?

When I did the version upgrade, I had some issues that were solved with backtracking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only difference was that line -c requirements.txt was missing in comments and obivously the command specified had the --resolver... So I would go as is

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nicobav nicobav merged commit 0fbd2c5 into main May 24, 2023
@nicobav nicobav deleted the bump-requests branch May 24, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants