Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11225: Removed everything related to chat leijuke #882

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Conversation

annadruid
Copy link
Contributor

@annadruid annadruid commented Jan 9, 2025

UHF-11225

What was done

  • Removed everything related to chat leijuke

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the Helfi Platform config
    • composer require drupal/helfi_platform_config:dev-UHF-11225
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11225
  • Run make drush-updb drush-cr

How to test

Test this pr in all instances that have different chats, strategia, kymp, etusivu, sote and asuminen

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Other PRs

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.14%. Comparing base (fb0ab91) to head (3d73b47).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #882      +/-   ##
============================================
+ Coverage     17.77%   19.14%   +1.36%     
+ Complexity      285      272      -13     
============================================
  Files            36       35       -1     
  Lines          1080     1003      -77     
============================================
  Hits            192      192              
+ Misses          888      811      -77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All other chats seem to work normally. Let's merge this once the "Sotebotti Hester" is in use. 🚀

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting this PR as "Request changes" to prevent accidental merge. The PR has been tested and approved, but it shouldn't be merged until the Sotebotti Hester is in use. See the ticket.

@annadruid annadruid marked this pull request as ready for review January 15, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants