UHF-10539: Unpublishable redirects

[hyrsky]

UHF-10539

What was done

The City wants to deactivate automatically made redirects after 6 months. This change alters redirect entity type from redirect module so that the entity implements EntityPublishedInterface and has field is_custom.

The redirect entities added or updated by any user from the entity from are automatically permanently marked as custom, while redirects created automatically are marked not custom. A cron job queries for non-custom redirect entities that are more that 6 months old, and unpublishes them.

How to install

• make fresh
• composer require drupal/helfi_platform_config:dev-UHF-10539
• drush updb -y
• drush cr

How to test

• Edit the title of any node so that the path alias should change. An automatic redirect from the old path alias to the new should be created. Check that the automatically created Redirect is not marked as custom: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect?is_custom=0&status=1
• Manually create redirect entity for any URL: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect/add. Check that the Redirect is marked as custom: https://helfi-etusivu.docker.so/fi/admin/config/search/redirect?is_custom=1&status=1
• Mark all redirect entities as NOT custom: drush sqlq "UPDATE redirect SET is_custom = 0"; drush cr
  • Check that the RedirectCleaner service unpublishes redirects that are older that 6 months: drush php:eval "\Drupal::service(\Drupal\helfi_platform_config\RedirectCleaner::class)->unpublishExpiredRedirects()"
  • Check that unpublished redirects do not work (should return 404).
  • Go to the redirect edit form and manually publish it, the redirect should now be marked custom and is not removed if RedirectCleaner::unpublishExpiredRedirects() is re-run.
• Check that code follows our standards

Continuous documentation

• This feature has been documented/the documentation has been updated
• This change doesn't require updates to the documentation

Translations

• Translations have been added to .po -files and included in this PR

Other PRs

• Link to other PR

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 17.89%. Comparing base (6c57a10) to head (950b694).
Report is 67 commits behind head on main.

Files with missing lines	Patch %	Lines
src/RedirectCleaner.php	89.65%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #862      +/-   ##
============================================
+ Coverage     14.49%   17.89%   +3.40%     
- Complexity      271      285      +14     
============================================
  Files            33       36       +3     
  Lines          1035     1084      +49     
============================================
+ Hits            150      194      +44     
- Misses          885      890       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[juho-lehmonen]

Looks good!