Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-9491: Allow rewriting config on update #699

Merged
merged 1 commit into from
Feb 27, 2024
Merged

UHF-9491: Allow rewriting config on update #699

merged 1 commit into from
Feb 27, 2024

Conversation

hyrsky
Copy link
Contributor

@hyrsky hyrsky commented Feb 27, 2024

UHF-9491

What was done

  • Allow instances to prevent updb from overwriting local configuration changes.

Other PRs

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 13.01%. Comparing base (2c441c9) to head (d768911).

❗ Current head d768911 differs from pull request most recent head c04319f. Consider uploading reports for the commit c04319f to get more accurate results

Files Patch % Lines
src/ConfigUpdate/ConfigUpdater.php 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #699      +/-   ##
============================================
- Coverage     13.07%   13.01%   -0.06%     
  Complexity      242      242              
============================================
  Files            28       28              
  Lines           941      945       +4     
============================================
  Hits            123      123              
- Misses          818      822       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This approach seems to work nicely! Good job! 💎 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants